add coeffects to CoreDataType::__shouldKBIC

Summary: this enables us to remove KBIC

Differential Revision: D76768905

fbshipit-source-id: 590adee71f26a8e9eace12b7061c5a0bb4ba8e62

Author: Diana Marsala

third-party/thrift/src/thrift/lib/hack/src/ThriftContextPropState.php

@@ -29,7 +29,7 @@ final class ThriftContextPropState {
   public static ?bool $setFBUserIdInPSP = null;
   public static ?bool $setIGUserIdInPSP = null;
 
-  private function __construct()[write_props, zoned_shallow] {
+  private function __construct()[write_props] {
     $this->storage = ThriftFrameworkMetadata::withDefaultValues();
     $this->serializedStorage = dict[];
   }
@@ -304,8 +304,7 @@ private static function coerceId(?int $id): ?int {
   /**
    * Returns the ThriftContextPropState singleton
    */
-  public static function get(
-  )[globals, write_props, zoned_shallow]: ThriftContextPropState {
+  public static function get()[globals, write_props]: ThriftContextPropState {
     if (self::$instance === null) {
       self::$instance = new ThriftContextPropState();
     }
@@ -547,7 +546,7 @@ public function addExperimentId(int $eid): void {
     $this->dirty();
   }
 
-  public function setExperimentIds(vec<int> $eids): void {
+  public function setExperimentIds(vec<int> $eids)[write_props]: void {
     $this->storage->experiment_ids = $eids;
     $this->dirty();
   }