Skip to content

Commit ad8cba0

Browse files
chessvivekfacebook-github-bot
authored andcommitted
Fix src consumption flag for DictSet and BespokeSet
Summary: Jan discovered this as we were reading through code. Reviewed By: jano Differential Revision: D76476211 fbshipit-source-id: a610e3763f3dfd9f097ef454f7cbca9e8e5e30fd
1 parent 69a0c30 commit ad8cba0

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

hphp/runtime/vm/jit/ir-instruction.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,6 @@ bool consumesRefImpl(const IRInstruction* inst, int srcNo) {
175175

176176
case DictSet:
177177
case BespokeSet:
178-
// Consumes the reference to its input array, and moves input value
179-
return move == Consume && (srcNo == 0 || srcNo == 2);
180-
181178
case BespokeSetPos:
182179
// Consumes the reference to its input array, and moves input value
183180
return (move == Consume && srcNo == 0) || srcNo == 2;

0 commit comments

Comments
 (0)