Plug in a function to publish metrics to scuba

Summary: Plugs in the log_metrics_tag pluggable function with an implementation to export metrics to scuba. There is a complexity that the standard loggers have a build dependency on the thrift compiler, meaning the thrift compiler cannot depend on the logger and create a circular dependency. Instead we use the `scribe_cat` cli tool to export the metrics

Reviewed By: iahs

Differential Revision: D76854422

fbshipit-source-id: e2547240c977b43c1787e8ea3b27bc8e6c2ba87c

Author: Charlie Cook

third-party/thrift/src/thrift/compiler/compiler.cc

@@ -81,6 +81,8 @@ void printUsageTo(FILE* stream) {
   -v[erbose]  Verbose mode
   -r[ecurse]  Also generate included files
   -debug      Parse debug trace to stdout
+  -no-log-metircs
+              Do not log metrics.
   --allow-neg-keys
               Allow negative field keys (IGNORED: always true).
   --allow-neg-enum-vals
@@ -682,6 +684,8 @@ std::string parse_args(
       }
     } else if (flag == "v" || flag == "verbose") {
       dparams.info = true;
+    } else if (flag == "no-log-metrics") {
+      dparams.log_metrics = false;
     } else if (flag == "r" || flag == "recurse") {
       gparams.gen_recurse = true;
     } else if (flag == "allow-neg-keys") {
@@ -954,8 +958,10 @@ compile_result compile_with_options(
           .count();
   ctx.metrics().get(detail::metrics::IntValue::RUNTIME).set(duration);
 
-  detail::pluggable_functions().call<log_metrics_tag>(
-      ctx.metrics(), ctx.params());
+  if (dparams.log_metrics) {
+    detail::pluggable_functions().call<log_metrics_tag>(
+        ctx.metrics(), ctx.params());
+  }
   return result;
 }
 

third-party/thrift/src/thrift/compiler/diagnostic.h

@@ -219,6 +219,7 @@ struct diagnostic_params {
   bool debug = false;
   bool info = false;
   int warn_level = 1;
+  bool log_metrics = true;
 
   bool should_report(diagnostic_level level) const {
     switch (level) {