Move t_type::get_scoped_name to t_named

Summary: Should've been in base class instead.

Reviewed By: sadroeck

Differential Revision: D76773055

fbshipit-source-id: d308dd9763f4c159a64dbcc3e68b43f674723f03

Author: praihan

third-party/thrift/src/thrift/compiler/ast/t_named.cc

@@ -21,6 +21,8 @@
 #include <thrift/compiler/ast/t_type.h>
 #include <thrift/compiler/ast/uri.h>
 
+#include <fmt/core.h>
+
 namespace apache::thrift::compiler {
 
 t_named::t_named(const t_program* program, std::string name)
@@ -41,6 +43,10 @@ t_named::t_named(const t_named& named)
 // NOTE: Must be defined here for t_const's destructor defintion.
 t_named::~t_named() = default;
 
+std::string t_named::get_scoped_name() const {
+  return program_ ? fmt::format("{}.{}", program_->name(), name_) : name_;
+}
+
 void t_named::add_structured_annotation(std::unique_ptr<t_const> annot) {
   assert(annot->type() != nullptr);
   structured_annotations_.emplace_back(std::move(annot));

third-party/thrift/src/thrift/compiler/ast/t_named.h

@@ -42,6 +42,9 @@ class t_named : public t_node {
   const std::string& name() const noexcept { return name_; }
   void set_name(const std::string& name) { name_ = name; }
 
+  // Returns a string in the format "program_name.type_name"
+  std::string get_scoped_name() const;
+
   node_list_view<const t_const> structured_annotations() const {
     return structured_annotations_;
   }

third-party/thrift/src/thrift/compiler/ast/t_type.cc

@@ -65,15 +65,6 @@ uint64_t t_type::get_type_id() const {
   return (hash & ~t_type::kTypeMask) | static_cast<int>(get_type_value());
 }
 
-std::string t_type::get_scoped_name() const {
-  std::ostringstream os;
-  if (program_) {
-    os << program_->name() << ".";
-  }
-  os << name_;
-  return os.str();
-}
-
 const t_type* t_type::get_true_type() const {
   return t_typedef::find_type_if(
       this, [](const t_type* type) { return !type->is_typedef(); });

third-party/thrift/src/thrift/compiler/ast/t_type.h

@@ -47,9 +47,6 @@ extern decltype(auto) visit_type(const t_type& ty, Visitors&&... visitors);
  */
 class t_type : public t_named {
  public:
-  // Returns a string in the format "program_name.type_name"
-  std::string get_scoped_name() const;
-
   // Returns the full name for the given type. For example:
   // `list<string, string>`
   virtual std::string get_full_name() const { return get_scoped_name(); }