Change the templating type for ThriftImmutableWrapper

Summary:
This change is required to make a generic toShape functionality (so it can be stringly typed).

See next diff.

Differential Revision: D76818825

fbshipit-source-id: 0ea793da4c1dd0624301aedcb918383d4626267d

Author: Francois Morin

third-party/thrift/src/thrift/lib/hack/src/ThriftImmutableWrapper.php

@@ -23,11 +23,14 @@
  * allow a caller to mutate the underlying thrift object.
  */
 <<__ConsistentConstruct, Oncalls('signals_infra')>>
-abstract class ThriftImmutableWrapper<T as \IThriftShapishSyncStruct>
+abstract class ThriftImmutableWrapper
   implements JsonSerializable, \HH\IMemoizeParam {
-  final public function __construct(protected T $data) {}
 
-  final public static function createInstance(?T $data): ?this {
+  abstract const type TThrift as IThriftShapishSyncStruct;
+
+  final public function __construct(protected this::TThrift $data) {}
+
+  final public static function createInstance(?this::TThrift $data): ?this {
     return $data is null ? null : new static($data);
   }
 
@@ -41,7 +44,7 @@ final public function getInstanceKey(): string {
     return $this->data->getInstanceKey();
   }
 
-  final public function createDeepCopy(): T {
+  final public function createDeepCopy(): this::TThrift {
     return TCompactSerializer::deserialize(
       TCompactSerializer::serialize($this->data),
       Classnames::get($this->data) as nonnull

third-party/thrift/src/thrift/lib/hack/src/__tests__/ThriftImmutableWrapperTest.php

@@ -91,8 +91,9 @@ final class ThriftImmutableWrapperTest extends WWWTest {
   }
 }
 
-final class TestThriftImmutableWrapper
-  extends ThriftImmutableWrapper<AdsConsentPlatformParams> {
+final class TestThriftImmutableWrapper extends ThriftImmutableWrapper {
+
+  const type TThrift = AdsConsentPlatformParams;
 
   public function getTraceId(): ?string {
     return $this->data->traceID;