fix random check in ThreadEntrySet::basicSanity

yfeldblum · facebook-github-bot · commit ed77e1b10167 · 2025-06-17T07:31:03.000-07:00
Summary: The check was accidentally inverted, causing debug-build code to spend more time in `ThreadEntrySet::basicSanity()` than desired. Likely affecting many unit-tests.

Reviewed By: dmm-fb

Differential Revision: D76755339

fbshipit-source-id: a4189a60fb6c27e0a50e83e37f786b00f71aa8d2
diff --git a/third-party/folly/src/folly/detail/ThreadLocalDetail.cpp b/third-party/folly/src/folly/detail/ThreadLocalDetail.cpp
@@ -70,7 +70,7 @@ bool ThreadEntrySet::basicSanity() const {
   auto const size = threadElements.size();
   rand_engine rng;
   std::uniform_int_distribution<size_t> dist{0, size - 1};
-  if (dist(rng) < constexpr_log2(size)) {
+  if (!(dist(rng) < constexpr_log2(size))) {
     return true;
   }
   return //

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ bool ThreadEntrySet::basicSanity() const {`
`70`	`70`	`auto const size = threadElements.size();`
`71`	`71`	`rand_engine rng;`
`72`	`72`	`std::uniform_int_distribution<size_t> dist{0, size - 1};`
`73`		`- if (dist(rng) < constexpr_log2(size)) {`
	`73`	`+ if (!(dist(rng) < constexpr_log2(size))) {`
`74`	`74`	`return true;`
`75`	`75`	`}`
`76`	`76`	`return //`