SonarCloud - WrongSecrets - Initial Scan 5.0

Author: mtech-software-solutions

src/main/java/org/owasp/wrongsecrets/Challenges.java

@@ -99,9 +99,9 @@ public boolean isFirstChallenge(ChallengeDefinition challengeDefinition) {
     return challengeDefinition.equals(definitions.challenges().get(0));
   }
 
-  public boolean isLastChallenge(ChallengeDefinition challengeDefinition) {
-    return challengeDefinition.equals(definitions.challenges().getLast());
-  }
+  // public boolean isLastChallenge(ChallengeDefinition challengeDefinition) {
+  //   return challengeDefinition.equals(definitions.challenges().getLast());
+  // }
 
   public List<ChallengeDefinition> getChallengeDefinitions() {
     return definitions.challenges();

src/main/java/org/owasp/wrongsecrets/challenges/ChallengeUI.java

@@ -104,14 +104,14 @@ public String previous() {
     return navigation.previous().map(this::getLink).orElse(null);
   }
 
-  private String documentation(Function<ChallengeSource, String> extractor) {
-    if (runtimeEnvironment.canRun(challengeDefinition)) {
-      return challengeDefinition.source(runtimeEnvironment).map(extractor).orElse("");
-    } else {
-      // We cannot run the challenge but showing documentation should still be possible
-      return extractor.apply(challengeDefinition.sources().getFirst());
-    }
-  }
+  // private String documentation(Function<ChallengeSource, String> extractor) {
+  //   if (runtimeEnvironment.canRun(challengeDefinition)) {
+  //     return challengeDefinition.source(runtimeEnvironment).map(extractor).orElse("");
+  //   } else {
+  //     // We cannot run the challenge but showing documentation should still be possible
+  //     return extractor.apply(challengeDefinition.sources().getFirst());
+  //   }
+  // }
 
   /**
    * Returns filename of the explanation of the challenge.

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java

@@ -84,28 +84,28 @@ public ChallengesController(
    * @param model exchanged with the FE
    * @return either a notification or a spoil
    */
-  @GetMapping("/spoil/{short-name}")
-  @Hidden
-  public String spoiler(@PathVariable("short-name") String shortName, Model model) {
-    if (ctfModeEnabled) {
-      model.addAttribute("spoiler", new Spoiler("Spoils are disabled in CTF mode"));
-    } else if (!spoilingEnabled) {
-      model.addAttribute("spoiler", new Spoiler("Spoils are disabled in the configuration"));
-    } else {
-      Optional<Spoiler> spoilerFromRuntimeEnvironment =
-          challenges.findChallenge(shortName, runtimeEnvironment).map(Challenge::spoiler);
-      Supplier<Spoiler> spoilerFromRandomChallenge =
-          () -> {
-            var challengeDefinition = findByShortName(shortName);
-            return challenges.getChallenge(challengeDefinition).getFirst().spoiler();
-          };
-
-      // We always want to show the spoiler even if we run in a non-supported environment
-      model.addAttribute(
-          "spoiler", spoilerFromRuntimeEnvironment.orElseGet(spoilerFromRandomChallenge));
-    }
-    return "spoil";
-  }
+  // @GetMapping("/spoil/{short-name}")
+  // @Hidden
+  // public String spoiler(@PathVariable("short-name") String shortName, Model model) {
+  //   if (ctfModeEnabled) {
+  //     model.addAttribute("spoiler", new Spoiler("Spoils are disabled in CTF mode"));
+  //   } else if (!spoilingEnabled) {
+  //     model.addAttribute("spoiler", new Spoiler("Spoils are disabled in the configuration"));
+  //   } else {
+  //     Optional<Spoiler> spoilerFromRuntimeEnvironment =
+  //         challenges.findChallenge(shortName, runtimeEnvironment).map(Challenge::spoiler);
+  //     Supplier<Spoiler> spoilerFromRandomChallenge =
+  //         () -> {
+  //           var challengeDefinition = findByShortName(shortName);
+  //           return challenges.getChallenge(challengeDefinition).getFirst().spoiler();
+  //         };
+
+  //     // We always want to show the spoiler even if we run in a non-supported environment
+  //     model.addAttribute(
+  //         "spoiler", spoilerFromRuntimeEnvironment.orElseGet(spoilerFromRandomChallenge));
+  //   }
+  //   return "spoil";
+  // }
 
   private void addChallengeUI(Model model, ChallengeDefinition challengeDefinition) {
     model.addAttribute(