Skip to content

Commit ba3e760

Browse files
refactor: Bump redis from 4.7.0 to 5.10.0 (parse-community#9994)
1 parent 82e0d3a commit ba3e760

File tree

6 files changed

+77
-97
lines changed

6 files changed

+77
-97
lines changed

package-lock.json

Lines changed: 73 additions & 89 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"pluralize": "8.0.0",
5656
"punycode": "2.3.1",
5757
"rate-limit-redis": "4.2.0",
58-
"redis": "4.7.0",
58+
"redis": "5.10.0",
5959
"semver": "7.7.2",
6060
"subscriptions-transport-ws": "0.11.0",
6161
"tv4": "1.3.0",

spec/RedisPubSub.spec.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ describe('RedisPubSub', function () {
2121
expect(redis.createClient).toHaveBeenCalledWith({
2222
url: 'redisAddress',
2323
socket_keepalive: true,
24-
no_ready_check: true,
2524
});
2625
});
2726

@@ -35,7 +34,6 @@ describe('RedisPubSub', function () {
3534
expect(redis.createClient).toHaveBeenCalledWith({
3635
url: 'redisAddress',
3736
socket_keepalive: true,
38-
no_ready_check: true,
3937
});
4038
});
4139

src/Adapters/Cache/RedisCacheAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export class RedisCacheAdapter {
3535
return;
3636
}
3737
try {
38-
await this.client.quit();
38+
await this.client.close();
3939
} catch (err) {
4040
logger.error('RedisCacheAdapter error on shutdown', { error: err });
4141
}

src/Adapters/PubSub/RedisPubSub.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { createClient } from 'redis';
22
import { logger } from '../../logger';
33

44
function createPublisher({ redisURL, redisOptions = {} }): any {
5-
redisOptions.no_ready_check = true;
65
const client = createClient({ url: redisURL, ...redisOptions });
76
client.on('error', err => { logger.error('RedisPubSub Publisher client error', { error: err }) });
87
client.on('connect', () => {});
@@ -12,7 +11,6 @@ function createPublisher({ redisURL, redisOptions = {} }): any {
1211
}
1312

1413
function createSubscriber({ redisURL, redisOptions = {} }): any {
15-
redisOptions.no_ready_check = true;
1614
const client = createClient({ url: redisURL, ...redisOptions });
1715
client.on('error', err => { logger.error('RedisPubSub Subscriber client error', { error: err }) });
1816
client.on('connect', () => {});

src/LiveQuery/ParseLiveQueryServer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ class ParseLiveQueryServer {
109109
this.subscriber.close?.(),
110110
]);
111111
}
112-
if (typeof this.subscriber.quit === 'function') {
112+
if (typeof this.subscriber.close === 'function') {
113113
try {
114-
await this.subscriber.quit();
114+
await this.subscriber.close();
115115
} catch (err) {
116116
logger.error('PubSubAdapter error on shutdown', { error: err });
117117
}

0 commit comments

Comments
 (0)