Fixed directly dereferencing parameter p7, CID 1576008

olszomal · mtrojnar · commit 4bd167a8bedd · 2025-03-31T13:19:35.000+02:00
diff --git a/osslsigncode.c b/osslsigncode.c
@@ -1357,7 +1357,7 @@ static int add_unauthenticated_blob(PKCS7 *p7, const char *blob_file)
         fprintf(stderr, "Failed to obtain PKCS#7 signer info list\n");
         return 0; /* FAILED */
     }
-    si = sk_PKCS7_SIGNER_INFO_value(p7->d.sign->signer_info, 0);
+    si = sk_PKCS7_SIGNER_INFO_value(signer_info, 0);
     if (!si) {
         fprintf(stderr, "Failed to obtain signer info from PKCS#7 structure\n");
         return 0; /* FAILED */

Original file line number	Diff line number	Diff line change
`@@ -1357,7 +1357,7 @@ static int add_unauthenticated_blob(PKCS7 p7, const char blob_file)`
`1357`	`1357`	`fprintf(stderr, "Failed to obtain PKCS#7 signer info list\n");`
`1358`	`1358`	`return 0; /* FAILED */`
`1359`	`1359`	`}`
`1360`		`- si = sk_PKCS7_SIGNER_INFO_value(p7->d.sign->signer_info, 0);`
	`1360`	`+ si = sk_PKCS7_SIGNER_INFO_value(signer_info, 0);`
`1361`	`1361`	`if (!si) {`
`1362`	`1362`	`fprintf(stderr, "Failed to obtain signer info from PKCS#7 structure\n");`
`1363`	`1363`	`return 0; /* FAILED */`