Skip to content

Commit b4ef771

Browse files
committed
Bump ruby versions
1 parent d3a9a95 commit b4ef771

File tree

6 files changed

+56
-61
lines changed

6 files changed

+56
-61
lines changed

.vscode/settings.json

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
{
2-
"ruby-lsc.commandWithArgs": [
3-
"docker-compose", "run", "--rm", "app"
4-
],
5-
"files.exclude": {
6-
"vendor": true
7-
}
2+
"ruby-lsc.commandWithArgs": ["docker-compose", "run", "--rm", "ruby-2-6"],
3+
"files.exclude": {
4+
"vendor": true
5+
}
86
}

circle.yml

Lines changed: 14 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
version: 2
22
jobs:
3-
test-2-5: &test
3+
ruby-2-6: &test
44
docker:
55
- image: tmaier/docker-compose
66
environment:
77
COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml
8-
SERVICE_NAME: ruby-2-5
98
steps:
109
- checkout
11-
- setup_remote_docker:
12-
version: 17.05.0-ce
10+
- setup_remote_docker
1311
- run:
1412
name: setup
1513
command: |
@@ -19,29 +17,16 @@ jobs:
1917
docker create -v project:/app --name project busybox chown -R 1000:1000 /app
2018
docker cp . project:/app
2119
docker start project
22-
docker-compose build $SERVICE_NAME
23-
- run: docker-compose run $SERVICE_NAME bin/ci
24-
test-2-4:
20+
docker-compose build $CIRCLE_JOB
21+
- run: docker-compose run $CIRCLE_JOB bin/ci
22+
ruby-2-5:
2523
<<: *test
26-
docker:
27-
- image: tmaier/docker-compose
28-
environment:
29-
COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml
30-
SERVICE_NAME: ruby-2-4
31-
test-2-3:
24+
ruby-2-4:
3225
<<: *test
33-
docker:
34-
- image: tmaier/docker-compose
35-
environment:
36-
COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml
37-
SERVICE_NAME: ruby-2-3
38-
test-2-2:
26+
ruby-2-3:
27+
<<: *test
28+
ruby-2-2:
3929
<<: *test
40-
docker:
41-
- image: tmaier/docker-compose
42-
environment:
43-
COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml
44-
SERVICE_NAME: ruby-2-2
4530
test-docker-build:
4631
docker:
4732
- image: docker
@@ -54,8 +39,9 @@ workflows:
5439
version: 2
5540
test:
5641
jobs:
57-
- test-2-5
58-
- test-2-4
59-
- test-2-3
60-
- test-2-2
42+
- ruby-2-6
43+
- ruby-2-5
44+
- ruby-2-4
45+
- ruby-2-3
46+
- ruby-2-2
6147
- test-docker-build

docker-compose.ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
version: '3.0'
1+
version: "3.0"
22
services:
3-
app: &app
3+
ruby-2-6: &latest
44
volumes:
55
- project:/app
66
ruby-2-5:
7-
<<: *app
7+
<<: *latest
88
ruby-2-4:
9-
<<: *app
9+
<<: *latest
1010
ruby-2-3:
11-
<<: *app
11+
<<: *latest
1212
ruby-2-2:
13-
<<: *app
13+
<<: *latest
1414
volumes:
1515
project:
1616
external: true

docker-compose.override.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
version: '3.0'
1+
version: "3.0"
22
services:
3-
app: &app
3+
ruby-2-6: &latest
44
volumes:
55
- .:/app:cached
66
- $HOME/.gitconfig:/home/ruby/.gitconfig:ro
77
- $HOME/.ssh:/home/ruby/.ssh:ro
88
- $HOME/.gem:/home/ruby/.gem
99
ruby-2-5:
10-
<<: *app
10+
<<: *latest
1111
ruby-2-4:
12-
<<: *app
12+
<<: *latest
1313
ruby-2-3:
14-
<<: *app
14+
<<: *latest
1515
ruby-2-2:
16-
<<: *app
16+
<<: *latest

docker-compose.yml

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,40 @@
1-
version: '3.0'
1+
version: "3.0"
22
services:
3-
app: &app
4-
build: &app-build
3+
ruby-2-6: &latest
4+
build: &build
55
context: .
66
dockerfile: Dockerfile.development
77
args:
8-
RUBY_VERSION: 2.5.0
8+
RUBY_VERSION: 2.6.0
99
environment:
1010
LANGUAGE_SERVER_RUBY_REMOTE_ROOT: $PWD
1111
volumes:
1212
- vendor:/vendor
1313
- home:/home/ruby
1414
ruby-2-5:
15-
<<: *app
15+
<<: *latest
16+
build:
17+
<<: *build
18+
args:
19+
RUBY_VERSION: 2.5.3
1620
ruby-2-4:
17-
<<: *app
21+
<<: *latest
1822
build:
19-
<<: *app-build
23+
<<: *build
2024
args:
21-
RUBY_VERSION: 2.4.3
25+
RUBY_VERSION: 2.4.5
2226
ruby-2-3:
23-
<<: *app
27+
<<: *latest
2428
build:
25-
<<: *app-build
29+
<<: *build
2630
args:
27-
RUBY_VERSION: 2.3.6
31+
RUBY_VERSION: 2.3.8
2832
ruby-2-2:
29-
<<: *app
33+
<<: *latest
3034
build:
31-
<<: *app-build
35+
<<: *build
3236
args:
33-
RUBY_VERSION: 2.2.9
37+
RUBY_VERSION: 2.2.10
3438
volumes:
3539
home:
3640
vendor:

test/language_server/linter/ruby_wc_test.rb

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,15 @@ def test_error
1919
10..11
2020
end
2121

22+
message =
23+
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.6.0")
24+
"unexpected backslash, expecting end-of-input"
25+
else
26+
"unexpected $undefined, expecting end-of-input"
27+
end
28+
2229
assert {
23-
linter.call == [Error.new(line_num: 1, characters: characters, message: "unexpected $undefined, expecting end-of-input", type: "syntax error")]
30+
linter.call == [Error.new(line_num: 1, characters: characters, message: message, type: "syntax error")]
2431
}
2532
end
2633

0 commit comments

Comments
 (0)