Skip to content

Commit f2c8640

Browse files
authored
Merge pull request #25 from mtsmfm/remove-sync
Stop using docker-sync
2 parents b785385 + 33eee3c commit f2c8640

9 files changed

+45
-28
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,3 @@
99
/tmp/
1010
/vendor/bundle/
1111
/node_modules/
12-
/.docker-sync

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Not released
44

55
- Add binstub bin/language_server-ruby
6+
- Stop using docker-sync for development
67

78
## 0.6.0
89

Dockerfile.development

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
ARG RUBY_VERSION=2.4.2
1+
ARG RUBY_VERSION=
22
FROM ruby:$RUBY_VERSION
33

44
RUN apt-get update && apt-get install less -y
55
RUN groupadd --gid 1000 ruby && useradd --uid 1000 --gid ruby --shell /bin/bash --create-home ruby
6-
RUN mkdir /app && chown ruby:ruby /app
6+
RUN mkdir /app /vendor && chown -R ruby:ruby /app /vendor
77

88
ENV LANG=C.UTF-8 \
9-
BUNDLE_PATH=/app/vendor/bundle/$RUBY_VERSION \
9+
BUNDLE_PATH=/vendor/bundle/$RUBY_VERSION \
1010
BUNDLE_JOBS=4
1111

1212
USER ruby

README.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,10 @@ Currently, language_server-ruby supports only stdio to communicate.
4848

4949
https://docs.docker.com/engine/installation
5050

51-
#### docker-sync
52-
53-
https://github.com/EugenMayer/docker-sync/wiki/1.-Installation
54-
5551
### Setup
5652

5753
$ git clone https://github.com/mtsmfm/language_server-ruby.git
5854
$ cd language_server-ruby
59-
$ docker-sync start
6055
$ docker-compose run app bin/setup
6156

6257
### Run test

circle.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ jobs:
44
docker:
55
- image: tmaier/docker-compose
66
environment:
7+
COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml
78
SERVICE_NAME: ruby-2-4
89
steps:
910
- checkout
@@ -13,23 +14,27 @@ jobs:
1314
name: setup
1415
command: |
1516
set -x
16-
docker volume create mtsmfm-language-server-sync
17-
docker create -v mtsmfm-language-server-sync:/app --name mtsmfm-language-server-sync busybox chown -R 1000:1000 /app
18-
docker cp . mtsmfm-language-server-sync:/app
19-
docker start mtsmfm-language-server-sync
17+
docker info
18+
docker volume create project
19+
docker create -v project:/app --name project busybox chown -R 1000:1000 /app
20+
docker cp . project:/app
21+
docker start project
22+
docker-compose build $SERVICE_NAME
2023
- run: docker-compose run $SERVICE_NAME bin/setup
2124
- run: docker-compose run $SERVICE_NAME bin/m
2225
test-2-3:
2326
<<: *test
2427
docker:
2528
- image: tmaier/docker-compose
2629
environment:
30+
COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml
2731
SERVICE_NAME: ruby-2-3
2832
test-2-2:
2933
<<: *test
3034
docker:
3135
- image: tmaier/docker-compose
3236
environment:
37+
COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml
3338
SERVICE_NAME: ruby-2-2
3439
workflows:
3540
version: 2

docker-compose.ci.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
version: '3.0'
2+
services:
3+
app: &app
4+
volumes:
5+
- project:/app
6+
ruby-2-4:
7+
<<: *app
8+
ruby-2-3:
9+
<<: *app
10+
ruby-2-2:
11+
<<: *app
12+
volumes:
13+
project:
14+
external: true

docker-compose.override.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
version: '3.0'
2+
services:
3+
app: &app
4+
volumes:
5+
- .:/app:cached
6+
- $HOME/.gitconfig:/home/ruby/.gitconfig:ro
7+
- $HOME/.ssh:/home/ruby/.ssh:ro
8+
- $HOME/.gem:/home/ruby/.gem
9+
ruby-2-4:
10+
<<: *app
11+
ruby-2-3:
12+
<<: *app
13+
ruby-2-2:
14+
<<: *app

docker-compose.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,13 @@ services:
44
build: &app-build
55
context: .
66
dockerfile: Dockerfile.development
7+
args:
8+
RUBY_VERSION: 2.4.2
79
environment:
810
LANGUAGE_SERVER_RUBY_REMOTE_ROOT: $PWD
911
volumes:
10-
- mtsmfm-language-server-sync:/app:nocopy
12+
- vendor:/vendor
1113
- home:/home/ruby
12-
- $HOME/.gitconfig:/home/ruby/.gitconfig:ro
13-
- $HOME/.ssh:/home/ruby/.ssh:ro
14-
- $HOME/.gem:/home/ruby/.gem
1514
ruby-2-4:
1615
<<: *app
1716
ruby-2-3:
@@ -27,6 +26,5 @@ services:
2726
args:
2827
RUBY_VERSION: 2.2.7
2928
volumes:
30-
mtsmfm-language-server-sync:
31-
external: true
3229
home:
30+
vendor:

docker-sync.yml

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)