Skip to content

Commit 74809c7

Browse files
erikapmadnificent
authored andcommitted
Update inline documentation on dependency installation
1 parent ed145a8 commit 74809c7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

run-development.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ fi
5555

5656
HAS_PACKAGE_LOCK=([ -f /app/package-lock.json ])
5757

58-
## Ensure we _sync_ the sources from the hosted app and _copy_ the node_modules.
58+
## Ensure we _sync_ the sources from the hosted app withouth the node_modules.
59+
## These are handled at a later stage when dependencies are installed.
5960
##
6061
## We don't want to do --delete on the node_modules because this allows us
6162
## to depend on the node_modules installed in an earlier update cycle as well as
@@ -65,7 +66,6 @@ HAS_PACKAGE_LOCK=([ -f /app/package-lock.json ])
6566
## node_modules in the template, or the node_modules may be offered in part or
6667
## in full. Hence we should only add the node_modules of the mounted code and
6768
## not remove anything.
68-
# TODO: this is related to installing dependencies, should this become part of npm-install-dependencies or should this be part of a copy-sources script.
6969
docker-rsync --delete --exclude node_modules /app/ /usr/src/app/app/
7070

7171
## Copy config folder

0 commit comments

Comments
 (0)