Commit ea9478c
committed
Only run npm install /app when starting non-production apps
The npm install functionality ran on each launch. The installed
packages are already fetched during the build phase, hence there
should be no reason to fetch the npm packages again unless we are
running in development mode.
The earlier implementations also did an npm install of the image's
packages. These should be bundled with the image and should not be
updated accidentally. Hence we choose to only run the npm install on
build of the template image, not on the build of the docker image
which uses this template.1 parent 2a87466 commit ea9478c
2 files changed
+4
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | 2 | | |
10 | 3 | | |
11 | 4 | | |
12 | 5 | | |
13 | 6 | | |
14 | 7 | | |
15 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
16 | 12 | | |
17 | 13 | | |
18 | 14 | | |
| |||
0 commit comments