Skip to content

Commit 38248af

Browse files
committed
Remove eval, update jquery
1 parent 7931fb6 commit 38248af

File tree

5 files changed

+19
-9
lines changed

5 files changed

+19
-9
lines changed

chrome/js/jquery.js

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

chrome/src/inject/inject.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,11 @@ function processRightCombinationBasedOnShortcut (shortcut, event) {
138138
keys.map(function(key) {
139139
index = combination.indexOf(key)
140140
if(index >= 0) {
141-
trueOrFalse.push( eval('event.' + key + 'Key' ) )
141+
if(key == "shift") trueOrFalse.push(event.shiftKey)
142+
if(key == "alt") trueOrFalse.push(event.altKey)
143+
if(key == "meta") trueOrFalse.push(event.metaKey)
144+
if(key == "crtl") trueOrFalse.push(event.ctrlKey)
145+
142146
combination.splice(index, 1)
143147
}
144148
})

firefox/data/index.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,11 @@ function processRightCombinationBasedOnShortcut (shortcut, event) {
141141
keys.map(function(key) {
142142
index = combination.indexOf(key)
143143
if(index >= 0) {
144-
trueOrFalse.push( eval('event.' + key + 'Key' ) )
144+
if(key == "shift") trueOrFalse.push(event.shiftKey)
145+
if(key == "alt") trueOrFalse.push(event.altKey)
146+
if(key == "meta") trueOrFalse.push(event.metaKey)
147+
if(key == "crtl") trueOrFalse.push(event.ctrlKey)
148+
145149
combination.splice(index, 1)
146150
}
147151
})

firefox/data/jquery.js

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

firefox/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@
3131
"value": "^\\((.+)\\)"
3232
}],
3333
"license": "MIT",
34-
"version": "0.1"
34+
"version": "0.1.1"
3535
}

0 commit comments

Comments
 (0)