Refactor css_path logic into it’s own method

Remove a few unnecessary comments in the penthouse config

Author: michael-misshore

lib/critical_path_css/css_fetcher.rb

@@ -10,33 +10,21 @@ def initialize(config)
     end
 
     def fetch
-      @config.routes.map.with_index { |route, index|
-        css_path = @config.css_paths[index].present? ? @config.css_paths[index] : @config.css_path
-        [route, css_for_route(route, css_path)]
-      }.to_h
+      @config.routes.map { |route| [route, fetch_route(route)] }.to_h
     end
 
     def fetch_route(route)
-      css_for_route route
-    end
-
-    protected
-
-    def css_for_route(route, css_path)
       options = {
         'url' => @config.base_url + route,
-        'css' => css_path,
-        ## optional params
-        # viewport dimensions
+        'css' => fetch_css_path_for_route(route), #implement
         'width' => 1300,
         'height' => 900,
+        'timeout' => 30_000,
         # CSS selectors to always include, e.g.:
         'forceInclude' => [
           #  '.keepMeEvenIfNotSeenInDom',
           #  '^\.regexWorksToo'
         ],
-        # ms; abort critical CSS generation after this timeout
-        'timeout' => 30_000,
         # set to true to throw on CSS errors (will run faster if no errors)
         'strict' => false,
         # characters; strip out inline base64 encoded resources larger than this
@@ -63,5 +51,17 @@ def css_for_route(route, css_path)
       end
       out
     end
+
+    private
+
+    def fetch_css_path_for_route(route)
+      index_for_route = @config.routes.index(route)
+
+      if index_for_route && @config.css_paths[index_for_route]
+        @config.css_paths[index_for_route]
+      else
+        @config.css_path
+      end
+    end
   end
 end