Skip to content

Commit b48b207

Browse files
Refactor: Resolved linting errors
1 parent fd2d11b commit b48b207

18 files changed

+164
-176
lines changed

src/main/java/com/sample/ecommerce/order/OrderApplication.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
@SpringBootApplication
77
public class OrderApplication {
88

9-
public static void main(String[] args) {
10-
SpringApplication.run(OrderApplication.class, args);
11-
}
9+
public static void main(String[] args) {
10+
SpringApplication.run(OrderApplication.class, args);
11+
}
1212

1313
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package com.sample.ecommerce.order.constants;
22

33
public enum OrderStatus {
4-
INITIATED,CANCELLED,CONFIRMED,FAILED
4+
INITIATED, CANCELLED, CONFIRMED, FAILED
55
}
Lines changed: 25 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
package com.sample.ecommerce.order.controller;
22

3+
import com.sample.ecommerce.order.dto.OrderDto;
4+
import com.sample.ecommerce.order.model.Order;
5+
import com.sample.ecommerce.order.service.OrderService;
6+
import jakarta.validation.Valid;
37
import java.util.List;
4-
58
import org.springframework.beans.factory.annotation.Autowired;
69
import org.springframework.web.bind.annotation.DeleteMapping;
710
import org.springframework.web.bind.annotation.GetMapping;
@@ -12,12 +15,6 @@
1215
import org.springframework.web.bind.annotation.RequestMapping;
1316
import org.springframework.web.bind.annotation.RestController;
1417

15-
import com.sample.ecommerce.order.dto.OrderDto;
16-
import com.sample.ecommerce.order.model.Order;
17-
import com.sample.ecommerce.order.service.OrderService;
18-
19-
import jakarta.validation.Valid;
20-
2118
@RestController
2219
@RequestMapping("/order/v1/orders")
2320
public class OrderController {
@@ -26,32 +23,33 @@ public class OrderController {
2623
OrderService service;
2724

2825
/*
29-
* To check health, we can use actuator which provides the endpoint http://localhost:8080/actuator/health
26+
* To check health, we can use actuator which provides the endpoint
27+
* http://localhost:8080/actuator/health
3028
*/
3129

32-
@PostMapping()
33-
public Order create(@Valid @RequestBody OrderDto createOrder){
30+
@PostMapping()
31+
public Order create(@Valid @RequestBody OrderDto createOrder) {
3432
return service.create(createOrder);
35-
}
33+
}
3634

37-
@GetMapping("/{id}")
38-
public Order findOne(@PathVariable int id){
35+
@GetMapping("/{id}")
36+
public Order findOne(@PathVariable int id) {
3937
return service.findOne(id);
40-
}
41-
@GetMapping()
42-
public List<Order> findAll(){
38+
}
39+
40+
@GetMapping()
41+
public List<Order> findAll() {
4342
return service.findAll();
44-
}
43+
}
4544

46-
@PutMapping("/{id}")
47-
public Order update(@PathVariable int id, @Valid @RequestBody OrderDto updateOrder){
48-
return service.update(id,updateOrder);
49-
}
45+
@PutMapping("/{id}")
46+
public Order update(@PathVariable int id, @Valid @RequestBody OrderDto updateOrder) {
47+
return service.update(id, updateOrder);
48+
}
5049

51-
@DeleteMapping("/{id}")
52-
public void delete(@PathVariable int id){
50+
@DeleteMapping("/{id}")
51+
public void delete(@PathVariable int id) {
5352
service.delete(id);
54-
}
55-
56-
}
57-
53+
}
54+
55+
}

src/main/java/com/sample/ecommerce/order/dto/OrderDto.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
package com.sample.ecommerce.order.dto;
2-
3-
import lombok.Getter;
4-
import lombok.Setter;
5-
import lombok.NoArgsConstructor;
1+
package com.sample.ecommerce.order.dto;
62

73
import com.sample.ecommerce.order.constants.OrderStatus;
8-
94
import lombok.AllArgsConstructor;
105
import lombok.Builder;
6+
import lombok.Getter;
7+
import lombok.NoArgsConstructor;
8+
import lombok.Setter;
119

1210

1311
@Getter
@@ -16,7 +14,7 @@
1614
@NoArgsConstructor
1715
@Builder
1816
public class OrderDto {
19-
17+
2018
private Integer customerId;
2119

2220
private OrderStatus status;

src/main/java/com/sample/ecommerce/order/exception/CommonException.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
@Getter
99
@AllArgsConstructor
1010
public class CommonException extends RuntimeException {
11-
private HttpStatus statusCode;
12-
private String errorCode;
13-
private String message;
11+
private HttpStatus statusCode;
12+
private String errorCode;
13+
private String message;
1414
}

src/main/java/com/sample/ecommerce/order/exception/ExceptionCodes.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
public final class ExceptionCodes {
44
private ExceptionCodes() {
5-
};
5+
}
6+
67
public static final String OBJECT_NOT_FOUND = "OBJECT_NOT_FOUND";
78

89
}
Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.sample.ecommerce.order.exception;
22

33
import com.sample.ecommerce.order.exception.dto.ErrorResponse;
4-
54
import lombok.extern.log4j.Log4j2;
65
import org.springframework.http.ResponseEntity;
76
import org.springframework.web.bind.annotation.ControllerAdvice;
@@ -14,13 +13,13 @@
1413
@ControllerAdvice
1514
public class GlobalExceptionHandler extends ResponseEntityExceptionHandler {
1615

17-
@ExceptionHandler(value = CommonException.class)
18-
public @ResponseBody ResponseEntity<ErrorResponse>
19-
handleCommonException(CommonException ex) {
20-
log.error(ex.getStatusCode() + ":" + ex.getMessage());
21-
return ResponseEntity.status(ex.getStatusCode()).body(new ErrorResponse(
22-
ex.getStatusCode().value(), ex.getMessage(), ex.getErrorCode()));
23-
}
16+
@ExceptionHandler(value = CommonException.class)
17+
public @ResponseBody ResponseEntity<ErrorResponse>
18+
handleCommonException(CommonException ex) {
19+
log.error(ex.getStatusCode() + ":" + ex.getMessage());
20+
return ResponseEntity.status(ex.getStatusCode()).body(new ErrorResponse(
21+
ex.getStatusCode().value(), ex.getMessage(), ex.getErrorCode()));
22+
}
2423

2524
}
2625

src/main/java/com/sample/ecommerce/order/exception/ObjectNotFoundException.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,17 @@
55

66
@ResponseStatus(value = HttpStatus.NOT_FOUND)
77

8-
public class ObjectNotFoundException extends CommonException {
9-
8+
public class ObjectNotFoundException extends CommonException {
9+
1010
private static final long serialVersionUID = 1L;
1111

12-
public <T> ObjectNotFoundException(Class<T> entity) {
13-
super(HttpStatus.NOT_FOUND, ExceptionCodes.OBJECT_NOT_FOUND, entity.getSimpleName() + " not found");
14-
}
12+
public <T> ObjectNotFoundException(Class<T> entity) {
13+
super(HttpStatus.NOT_FOUND,
14+
ExceptionCodes.OBJECT_NOT_FOUND,
15+
entity.getSimpleName() + " not found");
16+
}
1517

16-
public <T> ObjectNotFoundException(Class<T> entity, String simpleName) {
17-
super(HttpStatus.NOT_FOUND, ExceptionCodes.OBJECT_NOT_FOUND, simpleName + " not found");
18+
public <T> ObjectNotFoundException(Class<T> entity, String simpleName) {
19+
super(HttpStatus.NOT_FOUND, ExceptionCodes.OBJECT_NOT_FOUND, simpleName + " not found");
1820
}
1921
}

src/main/java/com/sample/ecommerce/order/exception/dto/ErrorResponse.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,12 @@
99
@NoArgsConstructor
1010
public class ErrorResponse {
1111

12-
private int statusCode;
13-
private String message;
14-
private String errorCode;
12+
private int statusCode;
13+
private String message;
14+
private String errorCode;
1515

16-
17-
public ErrorResponse(String message) {
18-
super();
19-
this.message = message;
20-
}
16+
public ErrorResponse(String message) {
17+
super();
18+
this.message = message;
19+
}
2120
}
Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,17 @@
11
package com.sample.ecommerce.order.model;
22

3-
import java.util.List;
4-
53
import com.fasterxml.jackson.annotation.JsonBackReference;
6-
74
import jakarta.persistence.Entity;
85
import jakarta.persistence.GeneratedValue;
6+
import jakarta.persistence.GenerationType;
97
import jakarta.persistence.Id;
108
import jakarta.persistence.OneToMany;
11-
import jakarta.persistence.GenerationType;
12-
import lombok.Getter;
13-
import lombok.Setter;
14-
15-
import lombok.NoArgsConstructor;
9+
import java.util.List;
1610
import lombok.AllArgsConstructor;
1711
import lombok.Builder;
18-
12+
import lombok.Getter;
13+
import lombok.NoArgsConstructor;
14+
import lombok.Setter;
1915

2016
@Getter
2117
@Setter
@@ -28,13 +24,13 @@ public class Category {
2824
@Id
2925
@GeneratedValue(strategy = GenerationType.IDENTITY)
3026
private Integer id;
31-
32-
private String name;
33-
34-
private Integer parentCategory;
27+
28+
private String name;
29+
30+
private Integer parentCategory;
3531

3632
@OneToMany(mappedBy = "category")
3733
@JsonBackReference
3834
private List<Product> products;
39-
35+
4036
}

0 commit comments

Comments
 (0)