Fix generate assets feature tests

Author: JoeRobich

test/featureTests/assets.test.ts

@@ -7,7 +7,7 @@ import * as path from 'path';
 import * as protocol from '../../src/omnisharp/protocol';
 import * as vscode from 'vscode';
 import * as jsonc from 'jsonc-parser';
-// import { FormattingOptions } from 'jsonc-parser'; 
+// import { FormattingOptions } from 'jsonc-parser';
 
 import { AssetGenerator, ProgramLaunchType, replaceCommentPropertiesWithComments, updateJsonWithComments } from '../../src/assets';
 import { parse } from 'jsonc-parser';
@@ -29,24 +29,52 @@ suite("Asset generation: csproj", () => {
         segments.should.deep.equal(['${workspaceFolder}', 'testApp.csproj']);
     });
 
-    test("Generated tasks.json has the property GenerateFullPaths set to true ", () => {
+    test("Generated 'build' and 'publish' tasks have the property GenerateFullPaths set to true ", () => {
         let rootPath = path.resolve('testRoot');
         let info = createMSBuildWorkspaceInformation(path.join(rootPath, 'testApp.csproj'), 'testApp', 'netcoreapp1.0');
         let generator = new AssetGenerator(info, createMockWorkspaceFolder(rootPath));
         generator.setStartupProject(0);
         let tasksJson = generator.createTasksConfiguration();
 
-        tasksJson.tasks.forEach(task => task.args.should.contain("/property:GenerateFullPaths=true"));
+        // We do not check the watch task since this parameter can break hot reload scenarios.
+        tasksJson.tasks
+            .filter(task => task.label !== "watch")
+            .forEach(task => task.args.should.contain("/property:GenerateFullPaths=true"));
     });
 
-    test("Generated tasks.json has the consoleloggerparameters argument set to NoSummary", () => {
+    test("Generated 'build' and 'publish' tasks have the consoleloggerparameters argument set to NoSummary", () => {
         let rootPath = path.resolve('testRoot');
         let info = createMSBuildWorkspaceInformation(path.join(rootPath, 'testApp.csproj'), 'testApp', 'netcoreapp1.0');
         let generator = new AssetGenerator(info, createMockWorkspaceFolder(rootPath));
         generator.setStartupProject(0);
         let tasksJson = generator.createTasksConfiguration();
 
-        tasksJson.tasks.forEach(task => task.args.should.contain("/consoleloggerparameters:NoSummary"));
+        // We do not check the watch task since this parameter can break hot reload scenarios.
+        tasksJson.tasks
+            .filter(task => task.label !== "watch")
+            .forEach(task => task.args.should.contain("/consoleloggerparameters:NoSummary"));
+    });
+
+    test("Generated 'watch' task does not have the property GenerateFullPaths set to true ", () => {
+        let rootPath = path.resolve('testRoot');
+        let info = createMSBuildWorkspaceInformation(path.join(rootPath, 'testApp.csproj'), 'testApp', 'netcoreapp1.0');
+        let generator = new AssetGenerator(info, createMockWorkspaceFolder(rootPath));
+        generator.setStartupProject(0);
+        let tasksJson = generator.createTasksConfiguration();
+
+        const watchTask = tasksJson.tasks.find(task => task.label === "watch");
+        watchTask.args.should.not.contain("/property:GenerateFullPaths=true");
+    });
+
+    test("Generated 'watch' task does not have the consoleloggerparameters argument set to NoSummary", () => {
+        let rootPath = path.resolve('testRoot');
+        let info = createMSBuildWorkspaceInformation(path.join(rootPath, 'testApp.csproj'), 'testApp', 'netcoreapp1.0');
+        let generator = new AssetGenerator(info, createMockWorkspaceFolder(rootPath));
+        generator.setStartupProject(0);
+        let tasksJson = generator.createTasksConfiguration();
+
+        const watchTask = tasksJson.tasks.find(task => task.label === "watch");
+        watchTask.args.should.not.contain("/consoleloggerparameters:NoSummary");
     });
 
     test("Create tasks.json for nested project opened in workspace", () => {
@@ -205,80 +233,80 @@ suite("Asset generation: csproj", () => {
 
     test("Add a new item to JSON", () => {
         const existingItem = { name: 'existing-item' };
-        const original = { 
+        const original = {
             configurations: [
                 existingItem
             ]
         };
 
-        const newItem = { name: 'new-item' };        
+        const newItem = { name: 'new-item' };
         const updated = updateJsonWithComments(JSON.stringify(original), [newItem], 'configurations', 'name', /*formattingOptions*/ null);
         const parsed = jsonc.parse(updated);
         const configurations = parsed.configurations;
 
-        const expected = [ existingItem, newItem ];
+        const expected = [existingItem, newItem];
         configurations.should.deep.equal(expected);
     });
 
     test("Update item in JSON", () => {
         const existingItem = { name: 'existing-item', command: 'cmd' };
-        const original = { 
+        const original = {
             configurations: [
                 // this should update to have command dotnet, because the name is the same as our updated item
                 { name: 'build', command: 'old value' },
                 existingItem
             ]
         };
 
-        const updatedItem = { name: 'build', command: 'dotnet' }; 
-        
+        const updatedItem = { name: 'build', command: 'dotnet' };
+
         const updated = updateJsonWithComments(JSON.stringify(original), [updatedItem], 'configurations', 'name', /*formattingOptions*/ null);
         const parsed = jsonc.parse(updated);
         const configurations = parsed.configurations;
 
-        const expected = [ updatedItem, existingItem ];
+        const expected = [updatedItem, existingItem];
         configurations.should.deep.equal(expected);
     });
 
     test("Update JSON and preserve all comments", () => {
         const original = `
         // user comment in file
-        { 
+        {
             "configurations": [
                 { "name": "build", "command": "old value" },
-                { 
+                {
                     // user comment in their configuration
-                    "name": "existing-item", 
-                    "command": "cmd" 
+                    "name": "existing-item",
+                    "command": "cmd"
                 }
             ]
         }`;
 
-        const updatedItem = { name: 'build', command: 'dotnet' }; 
-        
+        const updatedItem = { name: 'build', command: 'dotnet' };
+
         const updated = updateJsonWithComments(original, [updatedItem], 'configurations', 'name', /*formattingOptions*/ null);
         const lines = updated.trim().split('\n');
-        
+
         lines[0].trim().should.equal('// user comment in file');
         lines[5].trim().should.equal('// user comment in their configuration');
     });
 
     test("Replace items named OS-COMMENTxxx with JSON comment syntax", () => {
         const original = `
-        { 
+        {
             "configurations": [
-                { 
-                    "name": "build", 
+                {
+                    "name": "build",
                     "OS-COMMENT": "This is a dotnet build command",
                     "OS-COMMENT2": "this is the default command.",
-                    "command": "dotnet build" 
+                    "command": "dotnet build"
                 },
             ]
         }`;
 
         let updated = replaceCommentPropertiesWithComments(original);
         let lines = updated.trim().split('\n');
-        
+
         lines[4].trim().should.equal('// This is a dotnet build command');
         lines[5].trim().should.equal('// this is the default command.');
     });