Update to version 1.23.6

Author: muhammadsammy

CHANGELOG.md

@@ -10,15 +10,19 @@
 * Renaming symbol fails within a file that had recently been renamed without saving changes.
   * As a workaround, make an edit within the file before using Rename Symbol.
 
-## 1.23.5 (Not yet released)
+## 1.23.6 (Not yet released)
+* Do not call updateBuffer if there are no changes. (PR: [#4170](https://github.com/OmniSharp/omnisharp-vscode/pull/4170))
+* Only skip file changed events when document is open. (PR: [#4178](https://github.com/OmniSharp/omnisharp-vscode/pull/4178))
+
+## 1.23.5 (November 3, 2020)
 * Set meaning of UseGlobalMono "auto" to "never" since Mono 6.12.0 still ships with MSBuild 16.7 (PR: [#4130](https://github.com/OmniSharp/omnisharp-vscode/pull/4130))
 * Ensure that the rename identifier and run code action providers do not apply changes twice (PR: [#4133](https://github.com/OmniSharp/omnisharp-vscode/pull/4133))
 * Do not send file changed events for .cs files (PR: [#4141](https://github.com/OmniSharp/omnisharp-vscode/pull/4141), [#4143](https://github.com/OmniSharp/omnisharp-vscode/pull/4143))
 * Update Razor to 6.0.0-alpha.1.20529.17:
   * Improvements to HTML colorization for non-C# portions of the document.
   * Bug fix - the `razor.format.enable` option is honored again
 
-## 1.23.4 (October, 19, 2020)
+## 1.23.4 (October 19, 2020)
 * Use incremental changes to update language server (PR: [#4088](https://github.com/OmniSharp/omnisharp-vscode/pull/4088))
 * Set meaning of UseGlobalMono "auto" to "always" now that Mono 6.12.0 ships with MSBuild 16.8 (PR: [#4115](https://github.com/OmniSharp/omnisharp-vscode/pull/4115))
 * Updated OmniSharp to 1.37.3

package-lock.json

@@ -1,10 +1,10 @@
 {
   "name": "csharp",
   "publisher": "muhammad-sammy",
-  "version": "1.23.5",
-  "description": "C# support for vscode-compatible editors (powered by OmniSharp).",
+  "version": "1.23.6",
+  "description": "C# support for vscode-compatible editors (powered by OmniSharp and NetCoreDbg).",
   "displayName": "C#",
-  "author": "Microsoft Corporation",
+  "author": "Muhammad Sammy",
   "license": "SEE LICENSE IN RuntimeLicenses/license.txt",
   "icon": "images/csharpIcon.png",
   "preview": false,

package.json

@@ -14,16 +14,21 @@ function forwardDocumentChanges(server: OmniSharpServer): IDisposable {
 
     return workspace.onDidChangeTextDocument(event => {
 
-        let { document } = event;
+        let { document, contentChanges } = event;
         if (document.isUntitled || document.languageId !== 'csharp' || document.uri.scheme !== 'file') {
             return;
         }
 
+        if (contentChanges.length === 0) {
+            // This callback fires with no changes when a document's state changes between "clean" and "dirty".
+            return;
+        }
+
         if (!server.isRunning()) {
             return;
         }
 
-        const lineChanges = event.contentChanges.map(function (change): LinePositionSpanTextChange {
+        const lineChanges = contentChanges.map(function (change): LinePositionSpanTextChange {
             const range = change.range;
             return {
                 NewText: change.text,
@@ -49,21 +54,23 @@ function forwardFileChanges(server: OmniSharpServer): IDisposable {
                 return;
             }
 
-            const docs = workspace.textDocuments.filter(doc => doc.uri.fsPath === uri.fsPath);
-            if (Array.isArray(docs) && docs.some(doc => !doc.isClosed)) {
-                // When a file changes on disk a FileSystemEvent is generated as well as a
-                // DidChangeTextDocumentEvent.The ordering of these is:
-                //  1. This method is called back. vscode's TextDocument has not yet been reloaded, so it has
-                //     the version from before the changes are applied.
-                //  2. vscode reloads the file, and fires onDidChangeTextDocument. The document has been updated,
-                //     and the changes have the delta.
-                // If we send this change to the server, then it will reload from the disk, which means it will
-                // be synchronized to the version after the changes. Then, onDidChangeTextDocument will fire and
-                // send the delta changes, which will cause the server to apply those exact changes. The results
-                // being that the file is now in an inconsistent state.
-                // If the document is closed, however, it will no longer be synchronized, so the text change will
-                // not be triggered and we should tell the server to reread from the disk.
-                return;
+            if (changeType === FileChangeType.Change) {
+                const docs = workspace.textDocuments.filter(doc => doc.uri.fsPath === uri.fsPath);
+                if (Array.isArray(docs) && docs.some(doc => !doc.isClosed)) {
+                    // When a file changes on disk a FileSystemEvent is generated as well as a
+                    // DidChangeTextDocumentEvent.The ordering of these is:
+                    //  1. This method is called back. vscode's TextDocument has not yet been reloaded, so it has
+                    //     the version from before the changes are applied.
+                    //  2. vscode reloads the file, and fires onDidChangeTextDocument. The document has been updated,
+                    //     and the changes have the delta.
+                    // If we send this change to the server, then it will reload from the disk, which means it will
+                    // be synchronized to the version after the changes. Then, onDidChangeTextDocument will fire and
+                    // send the delta changes, which will cause the server to apply those exact changes. The results
+                    // being that the file is now in an inconsistent state.
+                    // If the document is closed, however, it will no longer be synchronized, so the text change will
+                    // not be triggered and we should tell the server to reread from the disk.
+                    return;
+                }
             }
 
             const req = { FileName: uri.fsPath, changeType };