Update to 'v1.24.0'

Author: muhammadsammy

.github/workflows/release-ci.yml

@@ -52,6 +52,17 @@ jobs:
         asset_name: csharp-${{ env.VERSION }}-darwin-x64.vsix
         asset_content_type: application/zip
 
+    - name: Upload release build (linux-arm64)
+      id: upload-release-asset-linux-arm64
+      uses: actions/upload-release-asset@v1
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      with:
+        upload_url: ${{ github.event.release.upload_url }}
+        asset_path: ./csharp-${{ env.VERSION }}-linux-arm64.vsix
+        asset_name: csharp-${{ env.VERSION }}-linux-arm64.vsix
+        asset_content_type: application/zip
+
     - name: Upload release build (linux-x64)
       id: upload-release-asset-linux-x64
       uses: actions/upload-release-asset@v1

.vscode/launch.json

@@ -188,8 +188,8 @@
                 "updatePackageDependencies"
             ],
             "env": {
-                "NEW_DEPS_URLS": "https://download.visualstudio.microsoft.com/download/pr/47df6cf8-7648-4fff-9e9c-304f0202d31c/6cf1b92d91f942929922013b2139cca9/omnisharp-linux-x64-1.37.17.zip,https://download.visualstudio.microsoft.com/download/pr/47df6cf8-7648-4fff-9e9c-304f0202d31c/6f3d66d4ffa4fa627225221fb00e106e/omnisharp-linux-x86-1.37.17.zip,https://download.visualstudio.microsoft.com/download/pr/47df6cf8-7648-4fff-9e9c-304f0202d31c/9f560aead2b823079775c00110972c04/omnisharp-osx-1.37.17.zip,https://download.visualstudio.microsoft.com/download/pr/47df6cf8-7648-4fff-9e9c-304f0202d31c/c868258dbd98f22b60154552f432edfa/omnisharp-win-x64-1.37.17.zip,https://download.visualstudio.microsoft.com/download/pr/47df6cf8-7648-4fff-9e9c-304f0202d31c/66f82f6333721c464316d7daa07bc115/omnisharp-win-x86-1.37.17.zip",
-                "NEW_DEPS_VERSION": "1.37.17"
+                "NEW_DEPS_URLS": "https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-linux-arm64-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-linux-x64-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-linux-x86-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-osx-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-win-arm64-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-win-x64-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-win-x86-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-linux-arm64-net6.0-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-linux-x64-net6.0-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-osx-arm64-net6.0-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-osx-x64-net6.0-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-win-arm64-net6.0-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-win-x64-net6.0-1.38.0.zip,https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-win-x86-net6.0-1.38.0.zip",
+                "NEW_DEPS_VERSION": "1.38.0"
             },
             "cwd": "${workspaceFolder}"
         }

CHANGELOG.md

@@ -1,8 +1,9 @@
-## Known Issues in 1.23.17
+## Known Issues in 1.24.0
 
 * For Mono-based development (e.g. Unity) that requires full .NET framework, you need to set `"omnisharp.useGlobalMono": "always"`. The current value of "auto" will remain "never" until Mono [upgrades their bundled MSBuild version](https://github.com/mono/mono/issues/20250).
 * After selecting a solution filter (*.slnf) from the project selector, the solution's name will be displayed in the status bar instead of the filter's.
 * Known limitations with the preview Razor (cshtml) language service to be addressed in a future release:
+  * Not all platforms ship with the Razor LSP, such as Linux arm64.
   * Only ASP.NET Core projects are supported (no support for ASP.NET projects)
   * Error squiggles misaligned for expressions near the start of a new line
   * Emmet based abbreviation expansion is not yet supported (See note in readme for how to enable through your settings.json)
@@ -11,13 +12,44 @@
 * Renaming symbol fails within a file that had recently been renamed without saving changes.
   * As a workaround, make an edit within the file before using Rename Symbol.
 
-## 1.23.17
+## 1.24.0
+* Upgrade OmniSharp to 1.38.0 (PR: [#4961](https://github.com/OmniSharp/omnisharp-vscode/issues/4961))
+  * Build OmniSharp servers that run on .NET 6 SDK (PR: [omnisharp-roslyn#2291](https://github.com/OmniSharp/omnisharp-roslyn/pull/2291))
+  * Allow net6 build of O# to load newer .NET SDKs (PR: [omnisharp-roslyn#2308](https://github.com/OmniSharp/omnisharp-roslyn/pull/2308))
+  * Allow alternate versions of documents to be Semantically Highlighted (PR: [omnisharp-roslyn#2304](https://github.com/OmniSharp/omnisharp-roslyn/pull/2304))
+  * Pass the logger for loading projects. So errors occur in loading projects can be printed out. ([#4832](https://github.com/OmniSharp/omnisharp-vscode/issues/4832), PR: [omnisharp-roslyn#2288](https://github.com/OmniSharp/omnisharp-roslyn/pull/2288))
+  * Update OmniSharp.Cake dependencies (PR: [omnisharp-roslyn#2280](https://github.com/OmniSharp/omnisharp-roslyn/pull/2280))
+  * Ensure each published platform uses matching hostfxr library (PR: [omnisharp-roslyn#2272](https://github.com/OmniSharp/omnisharp-roslyn/pull/2272))
+  * Produce an Arm64 build for Linux (PR: [omnisharp-roslyn#2271](https://github.com/OmniSharp/omnisharp-roslyn/pull/2271))
+  * Use 6.0.100 SDK for building (PR: [omnisharp-roslyn#2269](https://github.com/OmniSharp/omnisharp-roslyn/pull/2269))
+  * Added Code of Conduct (PR: [omnisharp-roslyn#2266](https://github.com/OmniSharp/omnisharp-roslyn/pull/2266))
+  * Improved Cake/CSX info messages (PR: [omnisharp-roslyn#2264](https://github.com/OmniSharp/omnisharp-roslyn/pull/2264))
+* Send document buffer when semantically highlighting old document versions (PR: [#4915](https://github.com/OmniSharp/omnisharp-vscode/pull/4915))
+* Improved Regex syntax highlighting (PR: [#4902](https://github.com/OmniSharp/omnisharp-vscode/pull/4902))
+* .NET 6 bug fixes ([#4931](https://github.com/OmniSharp/omnisharp-vscode/issues/4931), PR: [#4950](https://github.com/OmniSharp/omnisharp-vscode/pull/4950))
+* Add File-scoped namespace snippet (PR: [#4948](https://github.com/OmniSharp/omnisharp-vscode/pull/4948))
+* Add searchNuGetOrgSymbolServer documentation (PR: [#4939](https://github.com/OmniSharp/omnisharp-vscode/pull/4939))
+* Fix 'watch' Task (PR: [#4932](https://github.com/OmniSharp/omnisharp-vscode/pull/4932))
+* Support using .NET 6 OmniSharp (PR: [#4926](https://github.com/OmniSharp/omnisharp-vscode/pull/4926))
+* Rename LaunchTarget.kind to not conflict with VSCode separators. ([#4907](https://github.com/OmniSharp/omnisharp-vscode/issues/4907), PR: [#4914](https://github.com/OmniSharp/omnisharp-vscode/pull/4914))
+* Label optional dependencies as external (PR: [#4905](https://github.com/OmniSharp/omnisharp-vscode/pull/4905))
+* Provide a friendly name for the Razor language (PR: [#4904](https://github.com/OmniSharp/omnisharp-vscode/pull/4904))
+* Update Debugger to 1.23.19 (PR: [4899](https://github.com/OmniSharp/omnisharp-vscode/pull/4899))
+* Add targetArch to Attach and documentation ([#4900](https://github.com/OmniSharp/omnisharp-vscode/pull/4900), PR: [#4901](https://github.com/OmniSharp/omnisharp-vscode/pull/4901))
+* Allow Linux Arm64 users to run the experimental O# build (PR: [#4892](https://github.com/OmniSharp/omnisharp-vscode/pull/4892))
+* Always send document text when Semantic Highlighting (PR: [#5003](https://github.com/OmniSharp/omnisharp-vscode/pull/5003))
+* Remove obsolete settings checks for Blazor debugging (PR: [#4964](https://github.com/OmniSharp/omnisharp-vscode/pull/4964))
+* Explicitly install vscode-nls as a dependency (PR: [#4980](https://github.com/OmniSharp/omnisharp-vscode/pull/4980))
+* Modernize code action provider (PR: [#4988](https://github.com/OmniSharp/omnisharp-vscode/pull/4988))
+* Fix OmnisharpDownloader tests (PR: [#4989](https://github.com/OmniSharp/omnisharp-vscode/pull/4989))
+
+## 1.23.17 (Dec 3rd, 2021)
 * Greatly improved download experience: when the C# extension is downloaded from the VS Code Marketplace, it will include all of its dependencies already ([#4775](https://github.com/OmniSharp/omnisharp-vscode/issues/4775))
 * Fix decompilation authorization check ([#4817](https://github.com/OmniSharp/omnisharp-vscode/issues/4817), PR: [#4821](https://github.com/OmniSharp/omnisharp-vscode/pull/4821))
 * Fix typo in Readme.md (PR: [#4819](https://github.com/OmniSharp/omnisharp-vscode/pull/4819))
 * Fix indentation level and spacing for xUnit fact snippet. (PR: [#4831](https://github.com/OmniSharp/omnisharp-vscode/pull/4831))
 * Support relative paths with omnisharp.testRunSettings (PR: [#4860](https://github.com/OmniSharp/omnisharp-vscode/pull/4860)) (PR: [#4849](https://github.com/OmniSharp/omnisharp-vscode/pull/4849))
-* Add `CimAttachItemsProvider` to replace `WmicAttachItemsProvider` (PR: [#4848](https://github.com/OmniSharp/omnisharp-vscode/pull/4848))       
+* Add `CimAttachItemsProvider` to replace `WmicAttachItemsProvider` (PR: [#4848](https://github.com/OmniSharp/omnisharp-vscode/pull/4848))
 * Enhance sourceFileMap documentation (PR: [#4844](https://github.com/OmniSharp/omnisharp-vscode/pull/4844))
 * Update the indentation level and spacing for the '"xUnit Test" fact' snippet. (PR: [#4831](https://github.com/OmniSharp/omnisharp-vscode/pull/4831))
 

README.md

@@ -29,19 +29,40 @@ then run `Extensions: Install from VSIX` from the command pallete and select the
 
 # From [OmniSharp/omnisharp-vscode](https://github.com/OmniSharp/omnisharp-vscode) README
 
-## Note about using .NET Core 3.1.40x SDKs
+## Using .NET 6 builds of OmniSharp
 
-The .NET 3.1.40x SDKs require version 16.7 of MSBuild.
+Starting with C# extension version 1.24.0, there is now an option to use build of OmniSharp that runs on the .NET 6 SDK. This build requires that the .NET 6 SDK be installed and does not use Visual Studio MSBuild tools or Mono. It only supports newer SDK-style projects that are buildable with `dotnet build`. Unity projects and other Full Framework projects are not supported.
+
+To use the .NET 6 build, set `omnisharp.useModernNet` to `true` in your VS Code settings and restart OmniSharp.
+
+## Note about using .NET Core 3.1.4xx SDKs
+
+The .NET 3.1.4xx SDKs require version 16.7 of MSBuild.
 
 For MacOS and Linux users who have Mono installed, this means you will need to set `omnisharp.useGlobalMono` to `never` until a version of Mono ships with MSBuild 16.7.
 
+You can also use the .NET 6 build of OmniSharp which runs on the .NET 6 SDK. See instructions above.
+
 ## Note about using .NET 5 SDKs
 
 The .NET 5 SDK requires version 16.8 of MSBuild.
 
 For Windows users who have Visual Studio installed, this means you will need to be on the latest Visual Studio 16.8 Preview.
+
 For MacOS and Linux users who have Mono installed, this means you will need to set `omnisharp.useGlobalMono` to `never` until a version of Mono ships with MSBuild 16.8.
 
+You can also use the .NET 6 build of OmniSharp which runs on the .NET 6 SDK. See instructions above.
+
+## Note about using .NET 6 SDKs
+
+The .NET 6 SDK requires version 16.10 of MSBuild.
+
+For Windows users who have Visual Studio installed, this means you will need to have Visual Studio 16.11 or newer installed.
+
+For MacOS and Linux users who have Mono installed, this means you will need to set `omnisharp.useGlobalMono` to `never` until a version of Mono ships with MSBuild 16.10.
+
+You can also use the .NET 6 build of OmniSharp which runs on the .NET 6 SDK. See instructions above.
+
 ### Emmet support in Razor files
 
 To enable emmet support, add the following to your settings.json:

debugger-launchjson.md

@@ -120,7 +120,7 @@ The `"console"` setting controls what console (terminal) window the target app i
 
 ## launchSettings.json support
 
-In addition to launch.json, launch options can be configured through a {cwd}/Properties/launchSettings.json file. The advantage of 
+In addition to launch.json, launch options can be configured through a launchSettings.json file. The advantage of 
 launchSettings.json is that it allows settings to be shared between Visual Studio Code, full Visual Studio, and `dotnet run`.
 
 To configure which launchSettings.json profile to use (or to prevent it from being used), set the `launchSettingsProfile` option:
@@ -146,11 +146,14 @@ If `launchSettingsProfile` is NOT specified, the first profile with `"commandNam
 
 If `launchSettingsProfile` is set to null/an empty string, then Properties/launchSettings.json will be ignored.
 
+By default, the debugger will search for launchSettings.json in {cwd}/Properties/launchSettings.json. To customize this path, set `launchSettingsFilePath`:
+
+   "launchSettingsFilePath": "${workspaceFolder}/<Relative-Path-To-Project-Directory/Properties/launchSettings.json"
+
 Restrictions:
-1. The launchSettings.json file must be in {cwd}/Properties/launchSettings.json
-2. Only profiles with `"commandName": "Project"` are supported.
-3. Only `environmentVariables`, `applicationUrl` and `commandLineArgs` properties are supported
-4. Settings in launch.json will take precedence over settings in launchSettings.json, so for example, if `args` 
+1. Only profiles with `"commandName": "Project"` are supported.
+2. Only `environmentVariables`, `applicationUrl` and `commandLineArgs` properties are supported
+3. Settings in launch.json will take precedence over settings in launchSettings.json, so for example, if `args` 
 is already set to something other than an empty string/array in `launch.json` then the launchSettings.json 
 content will be ignored.
 
@@ -256,6 +259,7 @@ The `symbolOptions` element allows customization of how the debugger searches fo
             "https://my-companies-symbols-server"
         ],
         "searchMicrosoftSymbolServer": true,
+        "searchNuGetOrgSymbolServer": true,
         "cachePath": "/symcache",
         "moduleFilter": {
             "mode": "loadAllButExcluded",
@@ -270,6 +274,8 @@ The `symbolOptions` element allows customization of how the debugger searches fo
 
 **searchMicrosoftSymbolServer**: If `true` the Microsoft Symbol server (https://msdl.microsoft.com/download/symbols) is added to the symbols search path. If unspecified, this option defaults to `false`.
 
+**searchNuGetOrgSymbolServer**: If `true` the Nuget.org Symbol server (https://symbols.nuget.org/download/symbols) is added to the symbols search path. If unspecified, this option defaults to `false`.
+
 **cachePath**": Directory where symbols downloaded from symbol servers should be cached. If unspecified, on Windows the debugger will default to %TEMP%\\SymbolCache, and on Linux and macOS the debugger will default to ~/.dotnet/symbolcache.
 
 **moduleFilter.mode**: This value is either `"loadAllButExcluded"` or `"loadOnlyIncluded"`. In `"loadAllButExcluded"` mode, the debugger loads symbols for all modules unless the module is in the 'excludedModules' array. In `"loadOnlyIncluded"` mode, the debugger will not attempt to load symbols for ANY module unless it is in the 'includedModules' array, or it is included through the 'includeSymbolsNextToModules' setting.
@@ -306,3 +312,17 @@ To disable Source Link for all URLs, use `"sourceLinkOptions": { "*": { "enabled
 If multiple entries cover the same URL, the more specific entry (the entry with the longer string length) will be used.
 
 Currently Source Link only works for source files that can be accessed without authentication. So, for example, the debugger can download source files from open source projects on GitHub, but it cannot download from private GitHub repos, or from Visual Studio Team Services.
+
+## Target Architecture options (macOS M1)
+
+.NET on Apple M1 supports both x86_64 and ARM64. When debugging, the architecture of the process the debugger is attaching to and the debugger must match. If they do not match, it may result in `Unknown Error: 0x80131c3c`.
+
+The extension will try to resolve `targetArchitecture` based on the output of `dotnet --info` in the PATH, else it will try to use the same architecture as VS Code.
+
+You can override this behavior by setting `targetArchitecture` in your `launch.json`.
+
+Example:
+
+```json
+    "targetArchitecture": "arm64"
+```