[combobox] Item with a `label` inside of it will cause a double click

[michaelhazan]

Bug report

Current behavior

Currently if a Combobox.Item has a label inside of it, clicking the label will make the Combobox.Item onClick function to run twice, causing it to select, and then deselect the item.

Expected behavior

To not double click and select the item as usual.

Reproducible example

https://stackblitz.com/edit/wmpqteut?file=index.html

Base UI version

v1.0.0

Which browser are you using?

Firefox

Which OS are you using?

Mac OS

[atomiks]

What's the use case for a label inside an item? <label>s don't serve an (accessible) purpose inside <Combobox.Item>. If you want each item to have a checkbox for multiple selection, it should be a visual-only style using <Combobox.ItemIndicator keepMounted>, without using the <Checkbox> component

[michaelhazan]

What's the use case for a label inside an item? <label>s don't serve an (accessible) purpose inside <Combobox.Item>. If you want each item to have a checkbox for multiple selection, it should be a visual-only style using <Combobox.ItemIndicator keepMounted>, without using the <Checkbox> component

@atomiks fair point..

in our scenario it just happened that this is the way our components are built, meaning we had a specific custom logic built around our Checkbox (that had a label) that we wanted to retain in the Combobox.Item.

i'll let you decide if this is truly a bug or just a incorrect use of the components.

[atomiks]

in our scenario it just happened that this is the way our components are built, meaning we had a specific custom logic built around our Checkbox (that had a label) that we wanted to retain in the Combobox.Item.

Got it, that sounds useful from an abstraction POV, but it is not semantically correct when it comes to a <Combobox.Item> parent container. I recommend extending the component abstraction (or creating a new one) to handle the concept of "visual-only" checkboxes. The native <label> interferes with the logic here since it has custom handling, and is probably cumbersome to workaround internally when it has a better/easier solution available