-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
Closed
Labels
internalBehind-the-scenes enhancement. Formerly called “core”.Behind-the-scenes enhancement. Formerly called “core”.ready to takeHelp wanted. Guidance available. There is a high chance the change will be acceptedHelp wanted. Guidance available. There is a high chance the change will be acceptedscope: docs-infraInvolves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).test
Description
The cleanest way I can think of would be to extract the script logic into packages-internal/scripts, test it there and leave just the CLI in the scripts directory.
Originally posted by @michaldudak in #43144 (comment)
For context, the script which takes care of verifying each internal link point to an existing page, and an existing anchor was doing nothing (except eating some CPU time)
It would be nice to have a test that ensures it fails
The idea would be to have two markdown files, one with broken links, one with ok links, and run test that ensure the script is failing on the correct one and passing the other one.
This should avoid the issue we got with the script silently failing because it detected no link
Search keywords:
Metadata
Metadata
Assignees
Labels
internalBehind-the-scenes enhancement. Formerly called “core”.Behind-the-scenes enhancement. Formerly called “core”.ready to takeHelp wanted. Guidance available. There is a high chance the change will be acceptedHelp wanted. Guidance available. There is a high chance the change will be acceptedscope: docs-infraInvolves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).test