[button] Remove duplicated className entries#48213
Draft
silviuaavram wants to merge 1 commit intomui:masterfrom
Draft
[button] Remove duplicated className entries#48213silviuaavram wants to merge 1 commit intomui:masterfrom
silviuaavram wants to merge 1 commit intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-48213--material-ui.netlify.app/ Bundle size report
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes duplicated CSS class entries on the Material UI Button root element by avoiding passing the same utility classes through both className and the classes prop path (via ButtonBase).
Changes:
- Remove
classes.rootfrom theclassNamepassed toButtonRoot, relying on the existingclasses={classes}forwarding to apply utility classes once.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mnajdova
reviewed
Apr 6, 2026
Member
There was a problem hiding this comment.
I think we should omit classes.root when we propagate the classes prop instead. We should do that on all components using ButtonBase.
What I meant was doing this:
<ButtonRoot
ownerState={ownerState}
className={clsx(contextProps.className, className, classes.root, positionClassName)}
component={component}
disabled={disabled || loading}
focusRipple={!disableFocusRipple}
focusVisibleClassName={clsx(classes.focusVisible, focusVisibleClassName)}
ref={ref}
internalNativeButton
type={type}
id={loading ? loadingId : idProp}
{...other}
// classes.root is already propagated in the className prop
classes={{...classes, root: {}}}
>
Member
|
I guess it's a regression since #25072. The issue is also present in v5: https://v5.mui.com/material-ui/react-button/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48189.
Button is sending both className and classes to ButtonRoot.