Merge pull request linkedin#776 from ygsa/master

bai · web-flow · commit b4622d8471f4 · 2023-06-01T10:24:23.000+03:00
Add DeleteConsumerMetrics for every delete consumer.
diff --git a/core/internal/storage/inmemory.go b/core/internal/storage/inmemory.go
@@ -11,6 +11,7 @@ package storage
 
 import (
 	"container/ring"
+	"github.com/linkedin/Burrow/core/internal/httpserver"
 	"math/rand"
 	"regexp"
 	"sync"
@@ -675,6 +676,7 @@ func (module *InMemoryStorage) deleteGroup(request *protocol.StorageRequest, req
 		delete(clusterMap.consumer, request.Group)
 	}
 	clusterMap.consumerLock.Unlock()
+	httpserver.DeleteConsumerMetrics(request.Cluster, request.Group)
 
 	requestLogger.Debug("ok")
 }

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ package storage`
`11`	`11`
`12`	`12`	`import (`
`13`	`13`	`"container/ring"`
	`14`	`+ "github.com/linkedin/Burrow/core/internal/httpserver"`
`14`	`15`	`"math/rand"`
`15`	`16`	`"regexp"`
`16`	`17`	`"sync"`
`@@ -675,6 +676,7 @@ func (module InMemoryStorage) deleteGroup(request protocol.StorageRequest, req`
`675`	`676`	`delete(clusterMap.consumer, request.Group)`
`676`	`677`	`}`
`677`	`678`	`clusterMap.consumerLock.Unlock()`
	`679`	`+ httpserver.DeleteConsumerMetrics(request.Cluster, request.Group)`
`678`	`680`
`679`	`681`	`requestLogger.Debug("ok")`
`680`	`682`	`}`