Commit 5471f68
authored
wpt: Make legacy
servo#40289 (comment) intend
to process `headless` param properly.
For either `servo` or `servodriver` binary, the expected behaviour is:
- When given one test, it should depends on cmd arg `--headless`
- With multiple tests, we always default to `--headless`
The subtle point is: `ServoWdspecBrowser` didn't process `headless`
param at all and always default to headless. Also, `executor_kwargs`
does not work for it but only `browser_kwargs` works as it does not use
`ServoExecutor`.
Testing: Manually tested with legacy driver, running in single/multiple
tests, with/without headless param, with wdspec or none-wdspec test.
Fixes: servo#40289 (comment)
---------
Signed-off-by: Euclid Ye <[email protected]>ServoWdspecBrowser work as intended (servo#40296)1 parent 3fa2e8c commit 5471f68
File tree
2 files changed
+7
-2
lines changed- tests/wpt
- meta
- tests/tools/wptrunner/wptrunner/browsers
2 files changed
+7
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
533229 | 533229 | | |
533230 | 533230 | | |
533231 | 533231 | | |
533232 | | - | |
| 533232 | + | |
533233 | 533233 | | |
533234 | 533234 | | |
533235 | 533235 | | |
| |||
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
| 100 | + | |
99 | 101 | | |
100 | 102 | | |
101 | 103 | | |
| |||
109 | 111 | | |
110 | 112 | | |
111 | 113 | | |
| 114 | + | |
| 115 | + | |
112 | 116 | | |
113 | 117 | | |
114 | 118 | | |
| |||
117 | 121 | | |
118 | 122 | | |
119 | 123 | | |
120 | | - | |
121 | 124 | | |
122 | 125 | | |
123 | 126 | | |
124 | 127 | | |
125 | 128 | | |
| 129 | + | |
| 130 | + | |
126 | 131 | | |
0 commit comments