Skip to content

Commit cc71bfd

Browse files
authored
Auto merge of servo#29810 - MendyBerger:master, r=Loirooriol
css `inset` should work on Layout 2020 <!-- Please describe your changes on the following line: --> `top`, `bottom`, `left`, `right`, are already implemented in layout-2020, so adding the shorthand can be enabled. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix servo#29705 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ I'm don't know if I need tests for this, how do I determine that? <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2 parents 002fe81 + 458df8c commit cc71bfd

File tree

8 files changed

+6
-216
lines changed

8 files changed

+6
-216
lines changed

components/style/properties/shorthands/position.mako.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -839,7 +839,7 @@ ${helpers.four_sides_shorthand(
839839
"inset",
840840
"%s",
841841
"specified::LengthPercentageOrAuto::parse",
842-
engines="gecko servo-2013",
842+
engines="gecko servo-2013 servo-2020",
843843
spec="https://drafts.csswg.org/css-logical/#propdef-inset",
844844
allow_quirks="No",
845845
)}
@@ -849,7 +849,7 @@ ${helpers.two_properties_shorthand(
849849
"inset-block-start",
850850
"inset-block-end",
851851
"specified::LengthPercentageOrAuto::parse",
852-
engines="gecko servo-2013",
852+
engines="gecko servo-2013 servo-2020",
853853
spec="https://drafts.csswg.org/css-logical/#propdef-inset-block"
854854
)}
855855

@@ -858,6 +858,6 @@ ${helpers.two_properties_shorthand(
858858
"inset-inline-start",
859859
"inset-inline-end",
860860
"specified::LengthPercentageOrAuto::parse",
861-
engines="gecko servo-2013",
861+
engines="gecko servo-2013 servo-2020",
862862
spec="https://drafts.csswg.org/css-logical/#propdef-inset-inline"
863863
)}

tests/wpt/meta/css/css-logical/animation-002.html.ini

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
[animation-002.html]
2+
expected: CRASH
3+
bug: https://github.com/servo/servo/issues/29891
4+
25
[Logical properties in animations respect the writing-mode]
36
expected: FAIL
47

tests/wpt/meta/css/css-logical/logical-box-inset.html.ini

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
[Test that inset shorthand sets longhands and serializes correctly.]
99
expected: FAIL
1010

11-
[Test that inset-* shorthands set the computed value of both logical and physical longhands, with 'writing-mode: horizontal-tb; direction: ltr; '.]
12-
expected: FAIL
13-
1411
[Test that logical inset-* properties share computed values with their physical associates, with 'writing-mode: horizontal-tb; direction: rtl; '.]
1512
expected: FAIL
1613

tests/wpt/meta/css/css-logical/parsing/inset-block-inline-shorthand.html.ini

Lines changed: 0 additions & 36 deletions
This file was deleted.

tests/wpt/meta/css/css-logical/parsing/inset-block-inline-valid.html.ini

Lines changed: 0 additions & 24 deletions
This file was deleted.

tests/wpt/meta/css/css-logical/parsing/inset-shorthand.html.ini

Lines changed: 0 additions & 60 deletions
This file was deleted.

tests/wpt/meta/css/css-logical/parsing/inset-valid.html.ini

Lines changed: 0 additions & 24 deletions
This file was deleted.

tests/wpt/meta/css/css-position/parsing/inset-valid.html.ini

Lines changed: 0 additions & 66 deletions
This file was deleted.

0 commit comments

Comments
 (0)