Skip to content

Commit f11c604

Browse files
authored
Auto merge of servo#29970 - mrobinson:remove-uwp, r=jdm
Remove UWP / Hololens support <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they remove a feature. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2 parents eebb0a5 + c58d74f commit f11c604

File tree

97 files changed

+54
-7084
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

97 files changed

+54
-7084
lines changed

.gitignore

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -55,22 +55,6 @@ Sessionx.vim
5555

5656
/unminified-js
5757

58-
# Hololens artifacts
59-
support/hololens/x64/
60-
support/hololens/ARM/
61-
support/hololens/ARM64/
62-
support/hololens/ServoApp/x64/
63-
support/hololens/ServoApp/ARM/
64-
support/hololens/ServoApp/ARM64/
65-
support/hololens/ServoApp/Generated Files/
66-
support/hololens/ServoApp/BundleArtifacts/
67-
support/hololens/ServoApp/support/
68-
support/hololens/ServoApp/Debug/
69-
support/hololens/ServoApp/Release/
70-
support/hololens/packages/
71-
support/hololens/AppPackages/
72-
support/hololens/.vs/
73-
7458
# Layout debugger trace files
7559
layout_trace*
7660

Cargo.lock

Lines changed: 0 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ manually, try the [manual build setup][manual-build].
4444
- Download and run [`rustup-init.exe`](https://win.rustup.rs/) then follow the onscreen instructions.
4545
- Install [chocolatey](https://chocolatey.org/)
4646
- Run `mach bootstrap`
47-
- *This will install CMake, Git, Ninja, NuGet, Python and the Visual Studio 2019 Build Tools
47+
- *This will install CMake, Git, Ninja, Python and the Visual Studio 2019 Build Tools
4848
via choco in an Administrator console. It can take quite a while.*
4949
- *If you already have Visual Studio 2019 installed, this may not install all necessary components.
5050
Please follow the Visual Studio 2019 installation instructions in the [manual setup][manual-build].*

Xargo.toml

Lines changed: 0 additions & 7 deletions
This file was deleted.

components/config/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ license = "MPL-2.0"
66
edition = "2018"
77
publish = false
88

9-
[features]
10-
uwp = []
11-
129
[lib]
1310
name = "servo_config"
1411
path = "lib.rs"

components/config/basedir.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,9 @@ pub fn default_config_dir() -> Option<PathBuf> {
3535
Some(config_dir)
3636
}
3737

38-
#[cfg(all(target_os = "windows", not(feature = "uwp")))]
38+
#[cfg(all(target_os = "windows"))]
3939
pub fn default_config_dir() -> Option<PathBuf> {
4040
let mut config_dir = ::dirs_next::config_dir().unwrap();
4141
config_dir.push("Servo");
4242
Some(config_dir)
4343
}
44-
45-
#[cfg(all(target_os = "windows", feature = "uwp"))]
46-
pub fn default_config_dir() -> Option<PathBuf> {
47-
None
48-
}

components/config/tests/prefs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ fn test_set_all_error_on_unknown_field() -> Result<(), Box<dyn Error>> {
244244
Ok(())
245245
}
246246

247-
#[cfg(not(any(target_os = "android", feature = "uwp")))]
247+
#[cfg(not(target_os = "android"))]
248248
#[test]
249249
fn test_default_config_dir_create_read_write() {
250250
let json_str = "{\

components/script/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ default = ["unrooted_must_root_lint"]
2121
webgl_backtrace = ["canvas_traits/webgl_backtrace"]
2222
js_backtrace = []
2323
refcell_backtrace = ["accountable-refcell"]
24-
uwp = ["js/uwp"]
2524
xr-profile = ["webxr-api/profile"]
2625

2726
[build-dependencies]

components/servo/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ no-wgl = ["canvas/no-wgl"]
2626
no_static_freetype = ["webrender/no_static_freetype"]
2727
profilemozjs = ["script/profilemozjs"]
2828
refcell_backtrace = ["script/refcell_backtrace"]
29-
uwp = ["servo_config/uwp", "script/uwp"]
3029
webdriver = ["webdriver_server"]
3130
webgl_backtrace = [
3231
"script/webgl_backtrace",

components/servo/lib.rs

Lines changed: 5 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -141,49 +141,14 @@ mod media_platform {
141141
use super::ServoMedia;
142142
use servo_media_gstreamer::GStreamerBackend;
143143

144-
#[cfg(feature = "uwp")]
145-
fn set_gstreamer_log_handler() {
146-
use gstreamer::{debug_add_log_function, DebugLevel};
147-
148-
debug_add_log_function(|cat, level, file, function, line, _, message| {
149-
let message = format!(
150-
"{:?} {:?} {:?}:{:?}:{:?} {:?}",
151-
cat.get_name(),
152-
level,
153-
file,
154-
line,
155-
function,
156-
message
157-
);
158-
match level {
159-
DebugLevel::Debug => debug!("{}", message),
160-
DebugLevel::Error => error!("{}", message),
161-
DebugLevel::Warning => warn!("{}", message),
162-
DebugLevel::Fixme | DebugLevel::Info => info!("{}", message),
163-
DebugLevel::Memdump | DebugLevel::Count | DebugLevel::Trace => {
164-
trace!("{}", message)
165-
},
166-
_ => (),
167-
}
168-
});
169-
}
170-
171144
#[cfg(any(windows, target_os = "macos"))]
172145
pub fn init() {
173-
// UWP apps have the working directory set appropriately. Win32 apps
174-
// do not and need some assistance finding the DLLs.
175-
let plugin_dir = if cfg!(feature = "uwp") {
176-
std::path::PathBuf::new()
177-
} else {
178-
let mut plugin_dir = std::env::current_exe().unwrap();
179-
plugin_dir.pop();
146+
let mut plugin_dir = std::env::current_exe().unwrap();
147+
plugin_dir.pop();
180148

181-
if cfg!(target_os = "macos") {
182-
plugin_dir.push("lib");
183-
}
184-
185-
plugin_dir
186-
};
149+
if cfg!(target_os = "macos") {
150+
plugin_dir.push("lib");
151+
}
187152

188153
let backend = match GStreamerBackend::init_with_plugins(
189154
plugin_dir,
@@ -196,10 +161,6 @@ mod media_platform {
196161
},
197162
};
198163
ServoMedia::init_with_backend(backend);
199-
#[cfg(feature = "uwp")]
200-
{
201-
set_gstreamer_log_handler();
202-
}
203164
}
204165

205166
#[cfg(not(any(windows, target_os = "macos")))]

0 commit comments

Comments
 (0)