Skip to content

Commit fb23514

Browse files
mukilanmukilan
committed
skip unit tests for now
1 parent 47ed911 commit fb23514

File tree

2 files changed

+117
-117
lines changed

2 files changed

+117
-117
lines changed

‎.github/workflows/linux.yml‎

Lines changed: 109 additions & 109 deletions
Original file line numberDiff line numberDiff line change
@@ -185,16 +185,16 @@ jobs:
185185
cp -r target/cargo-timings target/cargo-timings-linux
186186
- name: Smoketest
187187
run: xvfb-run ./mach smoketest --${{ inputs.profile }}
188-
- name: Script tests
189-
run: ./mach test-scripts
190-
- name: Unit tests
191-
if: ${{ inputs.unit-tests }}
192-
env:
193-
NEXTEST_RETRIES: 2 # https://github.com/servo/servo/issues/30683
194-
run: ./mach test-unit --${{ inputs.profile }}
195-
- name: Devtools tests
196-
if: ${{ false && inputs.unit-tests }} # FIXME #39273
197-
run: ./mach test-devtools --${{ inputs.profile }}
188+
# - name: Script tests
189+
# run: ./mach test-scripts
190+
# - name: Unit tests
191+
# if: ${{ inputs.unit-tests }}
192+
# env:
193+
# NEXTEST_RETRIES: 2 # https://github.com/servo/servo/issues/30683
194+
# run: ./mach test-unit --${{ inputs.profile }}
195+
# - name: Devtools tests
196+
# if: ${{ false && inputs.unit-tests }} # FIXME #39273
197+
# run: ./mach test-devtools --${{ inputs.profile }}
198198
- name: Archive build timing
199199
uses: actions/upload-artifact@v4
200200
with:
@@ -286,103 +286,103 @@ jobs:
286286
287287
# Runs the underlying job (“workload”) on a self-hosted runner if available,
288288
# with the help of a `runner-select` job and a `runner-timeout` job.
289-
runner-select-coverage:
290-
if: inputs.coverage
291-
runs-on: ubuntu-22.04
292-
outputs:
293-
unique-id: ${{ steps.select.outputs.unique-id }}
294-
selected-runner-label: ${{ steps.select.outputs.selected-runner-label }}
295-
is-self-hosted: ${{ steps.select.outputs.is-self-hosted }}
296-
steps:
297-
- name: Runner select
298-
id: select
299-
uses: servo/ci-runners/actions/runner-select@0b9edd49381b22c14e5b123f21377269864ddf54
300-
with:
301-
GITHUB_TOKEN: ${{ github.token }}
302-
# Before updating the GH action runner image for the nightly job, ensure
303-
# that the system has a glibc version that is compatible with the one
304-
# used by the wpt.fyi runners.
305-
github-hosted-runner-label: ubuntu-22.04
306-
self-hosted-image-name: servo-ubuntu2204
307-
# You can disable self-hosted runners globally by creating a repository variable named
308-
# NO_SELF_HOSTED_RUNNERS with any non-empty value.
309-
# <https://github.com/servo/servo/settings/variables/actions>
310-
NO_SELF_HOSTED_RUNNERS: ${{ vars.NO_SELF_HOSTED_RUNNERS }}
311-
# Any other boolean conditions that disable self-hosted runners go here.
312-
force-github-hosted-runner: ${{ inputs.force-github-hosted-runner }}
313-
runner-timeout-coverage:
314-
needs:
315-
- runner-select-coverage
316-
if: inputs.coverage && fromJSON(needs.runner-select-coverage.outputs.is-self-hosted)
317-
runs-on: ubuntu-22.04
318-
steps:
319-
- name: Runner timeout
320-
uses: servo/ci-runners/actions/runner-timeout@0b9edd49381b22c14e5b123f21377269864ddf54
321-
with:
322-
github_token: '${{ secrets.GITHUB_TOKEN }}'
323-
unique-id: '${{ needs.runner-select-coverage.outputs.unique-id }}'
289+
# runner-select-coverage:
290+
# if: inputs.coverage
291+
# runs-on: ubuntu-22.04
292+
# outputs:
293+
# unique-id: ${{ steps.select.outputs.unique-id }}
294+
# selected-runner-label: ${{ steps.select.outputs.selected-runner-label }}
295+
# is-self-hosted: ${{ steps.select.outputs.is-self-hosted }}
296+
# steps:
297+
# - name: Runner select
298+
# id: select
299+
# uses: servo/ci-runners/actions/runner-select@0b9edd49381b22c14e5b123f21377269864ddf54
300+
# with:
301+
# GITHUB_TOKEN: ${{ github.token }}
302+
# # Before updating the GH action runner image for the nightly job, ensure
303+
# # that the system has a glibc version that is compatible with the one
304+
# # used by the wpt.fyi runners.
305+
# github-hosted-runner-label: ubuntu-22.04
306+
# self-hosted-image-name: servo-ubuntu2204
307+
# # You can disable self-hosted runners globally by creating a repository variable named
308+
# # NO_SELF_HOSTED_RUNNERS with any non-empty value.
309+
# # <https://github.com/servo/servo/settings/variables/actions>
310+
# NO_SELF_HOSTED_RUNNERS: ${{ vars.NO_SELF_HOSTED_RUNNERS }}
311+
# # Any other boolean conditions that disable self-hosted runners go here.
312+
# force-github-hosted-runner: ${{ inputs.force-github-hosted-runner }}
313+
# runner-timeout-coverage:
314+
# needs:
315+
# - runner-select-coverage
316+
# if: inputs.coverage && fromJSON(needs.runner-select-coverage.outputs.is-self-hosted)
317+
# runs-on: ubuntu-22.04
318+
# steps:
319+
# - name: Runner timeout
320+
# uses: servo/ci-runners/actions/runner-timeout@0b9edd49381b22c14e5b123f21377269864ddf54
321+
# with:
322+
# github_token: '${{ secrets.GITHUB_TOKEN }}'
323+
# unique-id: '${{ needs.runner-select-coverage.outputs.unique-id }}'
324324

325-
unit-test-coverage:
326-
if: inputs.coverage
327-
needs: runner-select-coverage
328-
name: Unit Test Coverage [${{ needs.runner-select-coverage.outputs.unique-id }}]
329-
runs-on: ${{ needs.runner-select-coverage.outputs.selected-runner-label }}
330-
continue-on-error: true
331-
steps:
332-
- uses: servo/ci-runners/actions/checkout@0b9edd49381b22c14e5b123f21377269864ddf54
333-
- name: Free Disk Space (Ubuntu)
334-
uses: jlumbroso/free-disk-space@main
335-
if: ${{ runner.environment != 'self-hosted' }}
336-
with:
337-
tool-cache: false
338-
large-packages: false
339-
swap-storage: false
340-
- name: Set LIBCLANG_PATH env # needed for bindgen in mozangle
341-
shell: bash
342-
if: ${{ runner.environment != 'self-hosted' }}
343-
run: echo "LIBCLANG_PATH=/usr/lib/llvm-14/lib" >> $GITHUB_ENV
344-
- name: Setup Python
345-
if: ${{ runner.environment != 'self-hosted' }}
346-
uses: ./.github/actions/setup-python
347-
- name: Change Mirror Priorities
348-
if: ${{ runner.environment != 'self-hosted' }}
349-
uses: ./.github/actions/apt-mirrors
350-
- name: Install cargo-llvm-cov
351-
uses: taiki-e/install-action@v2
352-
with:
353-
tool: cargo-llvm-cov,cargo-nextest
354-
- name: Bootstrap dependencies
355-
if: ${{ runner.environment != 'self-hosted' }}
356-
shell: bash
357-
run: |
358-
sudo apt update
359-
./mach bootstrap --skip-lints
360-
- name: Determine options
361-
id: options
362-
run: |
363-
if [[ ${{ runner.environment }} == 'self-hosted' ]];
364-
then
365-
CARGO_PROFILE=dev
366-
else
367-
# github hosted runners don't have enough diskspace for the dev profile.
368-
CARGO_PROFILE=coverage
369-
fi
370-
echo "cargo_profile=${CARGO_PROFILE}" | tee $GITHUB_OUTPUT
371-
# We can remove this after upgrading to Rust 1.90, but for now
372-
# installing lld is the easiest way to get it in path.
373-
- name: install lld
374-
run: sudo apt-get install -y lld
375-
- name: Run unit-tests with coverage
376-
shell: bash
377-
run: |
378-
./mach test-unit --code-coverage \
379-
--profile=${{ steps.options.outputs.cargo_profile }} \
380-
--llvm-cov-option=--codecov \
381-
--llvm-cov-option=--output-path=codecov.json
382-
- name: Upload coverage to Codecov
383-
uses: codecov/codecov-action@v5
384-
with:
385-
token: ${{ secrets.CODECOV_TOKEN }}
386-
files: codecov.json,support/crown/codecov.json
387-
fail_ci_if_error: true
388-
flags: unittests
325+
# unit-test-coverage:
326+
# if: inputs.coverage
327+
# needs: runner-select-coverage
328+
# name: Unit Test Coverage [${{ needs.runner-select-coverage.outputs.unique-id }}]
329+
# runs-on: ${{ needs.runner-select-coverage.outputs.selected-runner-label }}
330+
# continue-on-error: true
331+
# steps:
332+
# - uses: servo/ci-runners/actions/checkout@0b9edd49381b22c14e5b123f21377269864ddf54
333+
# - name: Free Disk Space (Ubuntu)
334+
# uses: jlumbroso/free-disk-space@main
335+
# if: ${{ runner.environment != 'self-hosted' }}
336+
# with:
337+
# tool-cache: false
338+
# large-packages: false
339+
# swap-storage: false
340+
# - name: Set LIBCLANG_PATH env # needed for bindgen in mozangle
341+
# shell: bash
342+
# if: ${{ runner.environment != 'self-hosted' }}
343+
# run: echo "LIBCLANG_PATH=/usr/lib/llvm-14/lib" >> $GITHUB_ENV
344+
# - name: Setup Python
345+
# if: ${{ runner.environment != 'self-hosted' }}
346+
# uses: ./.github/actions/setup-python
347+
# - name: Change Mirror Priorities
348+
# if: ${{ runner.environment != 'self-hosted' }}
349+
# uses: ./.github/actions/apt-mirrors
350+
# - name: Install cargo-llvm-cov
351+
# uses: taiki-e/install-action@v2
352+
# with:
353+
# tool: cargo-llvm-cov,cargo-nextest
354+
# - name: Bootstrap dependencies
355+
# if: ${{ runner.environment != 'self-hosted' }}
356+
# shell: bash
357+
# run: |
358+
# sudo apt update
359+
# ./mach bootstrap --skip-lints
360+
# - name: Determine options
361+
# id: options
362+
# run: |
363+
# if [[ ${{ runner.environment }} == 'self-hosted' ]];
364+
# then
365+
# CARGO_PROFILE=dev
366+
# else
367+
# # github hosted runners don't have enough diskspace for the dev profile.
368+
# CARGO_PROFILE=coverage
369+
# fi
370+
# echo "cargo_profile=${CARGO_PROFILE}" | tee $GITHUB_OUTPUT
371+
# # We can remove this after upgrading to Rust 1.90, but for now
372+
# # installing lld is the easiest way to get it in path.
373+
# - name: install lld
374+
# run: sudo apt-get install -y lld
375+
# - name: Run unit-tests with coverage
376+
# shell: bash
377+
# run: |
378+
# ./mach test-unit --code-coverage \
379+
# --profile=${{ steps.options.outputs.cargo_profile }} \
380+
# --llvm-cov-option=--codecov \
381+
# --llvm-cov-option=--output-path=codecov.json
382+
# - name: Upload coverage to Codecov
383+
# uses: codecov/codecov-action@v5
384+
# with:
385+
# token: ${{ secrets.CODECOV_TOKEN }}
386+
# files: codecov.json,support/crown/codecov.json
387+
# fail_ci_if_error: true
388+
# flags: unittests

‎.github/workflows/windows.yml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -176,14 +176,14 @@ jobs:
176176
- name: Install cargo nextest (self-hosted)
177177
if: ${{ runner.environment == 'self-hosted' }}
178178
run: cargo install cargo-nextest --locked
179-
- name: Unit tests
180-
if: ${{ inputs.unit-tests }}
181-
env:
182-
NEXTEST_RETRIES: 3 # https://github.com/servo/servo/issues/30683
183-
run: ./mach test-unit --${{ inputs.profile }}
184-
- name: Devtools tests
185-
if: ${{ false && inputs.unit-tests }} # FIXME #39273
186-
run: .\mach test-devtools --${{ inputs.profile }}
179+
# - name: Unit tests
180+
# if: ${{ inputs.unit-tests }}
181+
# env:
182+
# NEXTEST_RETRIES: 3 # https://github.com/servo/servo/issues/30683
183+
# run: ./mach test-unit --${{ inputs.profile }}
184+
# - name: Devtools tests
185+
# if: ${{ false && inputs.unit-tests }} # FIXME #39273
186+
# run: .\mach test-devtools --${{ inputs.profile }}
187187
- name: Archive build timing
188188
uses: actions/upload-artifact@v4
189189
with:

0 commit comments

Comments
 (0)