Skip to content

Commit 65ded8c

Browse files
author
Javier Isoldi
committed
Security schema's propagation support for 1.0 improved. #101.
1 parent 6fa2ed1 commit 65ded8c

File tree

3 files changed

+32
-16
lines changed

3 files changed

+32
-16
lines changed

dist/scripts/api-console.js

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@
124124
return {
125125
restrict: 'E',
126126
templateUrl: 'directives/documentation.tpl.html',
127-
replace: true,
128127
controller: ['$scope', function($scope) {
129128
var defaultSchemaKey = Object.keys($scope.securitySchemes).sort()[0];
130129
var defaultSchema = $scope.securitySchemes[defaultSchemaKey];
@@ -149,11 +148,19 @@
149148
}
150149

151150
function copyToCodesIfNotPresent(codes, schemaCodes) {
152-
Object.keys(schemaCodes).forEach(function (code) {
153-
if (schemaCodes.hasOwnProperty(code) && !codes.hasOwnProperty(code)) {
154-
codes[code] = schemaCodes[code];
155-
}
156-
});
151+
if (Array.isArray(schemaCodes)) {
152+
schemaCodes.forEach(function (response) {
153+
if (!codes.hasOwnProperty(response.code)) {
154+
codes[response.code] = response.code;
155+
}
156+
});
157+
} else {
158+
Object.keys(schemaCodes).forEach(function (code) {
159+
if (schemaCodes.hasOwnProperty(code) && !codes.hasOwnProperty(code)) {
160+
codes[code] = schemaCodes[code];
161+
}
162+
});
163+
}
157164
}
158165
$scope.fullResponses = mergeResponseCodes($scope.methodInfo.responses || {}, $scope.methodInfo.securitySchemes());
159166
$scope.fullResponseCodes = Object.keys($scope.fullResponses);
@@ -341,7 +348,8 @@
341348
$elements.removeClass('raml-console-is-active');
342349
$container.find('.raml-console-body-' + $scope.getBodyId(value)).addClass('raml-console-is-active');
343350
});
344-
}]
351+
}],
352+
replace: true
345353
};
346354
};
347355

@@ -6724,7 +6732,7 @@ angular.module('ramlConsoleApp').run(['$templateCache', function($templateCache)
67246732
" <div class=\"raml-console-sidebar-row\">\n" +
67256733
" <p class=\"raml-console-sidebar-input-container raml-console-sidebar-input-container-custom\" ng-repeat=\"customParam in context.customParameters[type]\">\n" +
67266734
" <button class=\"raml-console-sidebar-input-delete\" ng-click=\"removeCutomParam(customParam)\"></button>\n" +
6727-
" <label for=\"custom-header\" class=\"raml-console-sidebar-label raml-console-sidebar-label-custom\">\n" +
6735+
" <label class=\"raml-console-sidebar-label raml-console-sidebar-label-custom\">\n" +
67286736
" <input class=\"raml-console-sidebar-custom-input-for-label\" ng-model=\"customParam.name\" placeholder=\"custom key\">\n" +
67296737
" </label>\n" +
67306738
" <input name=\"custom-header\" class=\"raml-console-sidebar-input raml-console-sidebar-input-custom\" placeholder=\"custom value\" ng-model=\"customParam.value\">\n" +

src/app/directives/documentation.js

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
return {
66
restrict: 'E',
77
templateUrl: 'directives/documentation.tpl.html',
8-
replace: true,
98
controller: ['$scope', function($scope) {
109
var defaultSchemaKey = Object.keys($scope.securitySchemes).sort()[0];
1110
var defaultSchema = $scope.securitySchemes[defaultSchemaKey];
@@ -30,11 +29,19 @@
3029
}
3130

3231
function copyToCodesIfNotPresent(codes, schemaCodes) {
33-
Object.keys(schemaCodes).forEach(function (code) {
34-
if (schemaCodes.hasOwnProperty(code) && !codes.hasOwnProperty(code)) {
35-
codes[code] = schemaCodes[code];
36-
}
37-
});
32+
if (Array.isArray(schemaCodes)) {
33+
schemaCodes.forEach(function (response) {
34+
if (!codes.hasOwnProperty(response.code)) {
35+
codes[response.code] = response.code;
36+
}
37+
});
38+
} else {
39+
Object.keys(schemaCodes).forEach(function (code) {
40+
if (schemaCodes.hasOwnProperty(code) && !codes.hasOwnProperty(code)) {
41+
codes[code] = schemaCodes[code];
42+
}
43+
});
44+
}
3845
}
3946
$scope.fullResponses = mergeResponseCodes($scope.methodInfo.responses || {}, $scope.methodInfo.securitySchemes());
4047
$scope.fullResponseCodes = Object.keys($scope.fullResponses);
@@ -222,7 +229,8 @@
222229
$elements.removeClass('raml-console-is-active');
223230
$container.find('.raml-console-body-' + $scope.getBodyId(value)).addClass('raml-console-is-active');
224231
});
225-
}]
232+
}],
233+
replace: true
226234
};
227235
};
228236

src/app/directives/named-parameters.tpl.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ <h4 class="raml-console-sidebar-subhead">{{title}}</h4>
77
<div class="raml-console-sidebar-row">
88
<p class="raml-console-sidebar-input-container raml-console-sidebar-input-container-custom" ng-repeat="customParam in context.customParameters[type]">
99
<button class="raml-console-sidebar-input-delete" ng-click="removeCutomParam(customParam)"></button>
10-
<label for="custom-header" class="raml-console-sidebar-label raml-console-sidebar-label-custom">
10+
<label class="raml-console-sidebar-label raml-console-sidebar-label-custom">
1111
<input class="raml-console-sidebar-custom-input-for-label" ng-model="customParam.name" placeholder="custom key">
1212
</label>
1313
<input name="custom-header" class="raml-console-sidebar-input raml-console-sidebar-input-custom" placeholder="custom value" ng-model="customParam.value">

0 commit comments

Comments
 (0)