Skip to content

Commit 676871f

Browse files
Javier CenturiónJavier Centurión
authored andcommitted
Fix close resources
1 parent 6ab5c38 commit 676871f

File tree

3 files changed

+14
-34
lines changed

3 files changed

+14
-34
lines changed

dist/scripts/api-console.js

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,11 @@
9898
restrict: 'E',
9999
templateUrl: 'directives/close-button.tpl.html',
100100
replace: true,
101-
controller: function($scope) {
101+
controller: function($scope, $rootScope) {
102102
$scope.close = function () {
103103
var $inactiveElements = jQuery('.raml-console-tab').add('.raml-console-resource').add('li');
104104

105-
105+
$rootScope.$broadcast('resetData');
106106
$inactiveElements.removeClass('raml-console-is-active');
107107
$scope.showPanel = false;
108108
$scope.traits = null;
@@ -1136,8 +1136,10 @@
11361136
$scope.currentProtocol = $scope.raml.protocols[0];
11371137
$scope.documentationSchemeSelected = defaultSchema;
11381138
$scope.responseDetails = null;
1139-
removeCustomSchemeData($scope.context.headers);
1140-
removeCustomSchemeData($scope.context.queryParameters);
1139+
// removeCustomSchemeData($scope.context.headers);
1140+
// removeCustomSchemeData($scope.context.queryParameters);
1141+
cleanSchemeMetadata($scope.methodInfo.headers.plain, $scope.context.headers);
1142+
cleanSchemeMetadata($scope.methodInfo.queryParameters, $scope.context.queryParameters);
11411143
});
11421144

11431145
$scope.cancelRequest = function () {
@@ -1246,18 +1248,8 @@
12461248
}
12471249
}
12481250

1249-
function removeCustomSchemeData(context) {
1250-
Object.keys(context.plain).map(function (key) {
1251-
var isFromSecurityScheme = context.plain[key].definitions[0].isFromSecurityScheme;
1252-
1253-
if (isFromSecurityScheme) {
1254-
delete context.plain[key];
1255-
}
1256-
});
1257-
}
1258-
12591251
function updateContextData (type, scheme, collection, context) {
1260-
var details = $scope.securitySchemes[scheme].describedBy || {};
1252+
var details = jQuery.extend({}, $scope.securitySchemes[scheme].describedBy || {});
12611253
var securityHeaders = details[type] || {};
12621254

12631255
if (securityHeaders) {
@@ -1295,8 +1287,6 @@
12951287
$scope.currentSchemeType = type;
12961288
$scope.context.forceRequest = false;
12971289

1298-
readCustomSchemeInfo(name);
1299-
13001290
cleanSchemeMetadata($scope.methodInfo.headers.plain, $scope.context.headers);
13011291
cleanSchemeMetadata($scope.methodInfo.queryParameters, $scope.context.queryParameters);
13021292

src/app/directives/close-button.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
restrict: 'E',
77
templateUrl: 'directives/close-button.tpl.html',
88
replace: true,
9-
controller: function($scope) {
9+
controller: function($scope, $rootScope) {
1010
$scope.close = function () {
1111
var $inactiveElements = jQuery('.raml-console-tab').add('.raml-console-resource').add('li');
1212

13-
13+
$rootScope.$broadcast('resetData');
1414
$inactiveElements.removeClass('raml-console-is-active');
1515
$scope.showPanel = false;
1616
$scope.traits = null;

src/app/directives/sidebar.js

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,10 @@
199199
$scope.currentProtocol = $scope.raml.protocols[0];
200200
$scope.documentationSchemeSelected = defaultSchema;
201201
$scope.responseDetails = null;
202-
removeCustomSchemeData($scope.context.headers);
203-
removeCustomSchemeData($scope.context.queryParameters);
202+
// removeCustomSchemeData($scope.context.headers);
203+
// removeCustomSchemeData($scope.context.queryParameters);
204+
cleanSchemeMetadata($scope.methodInfo.headers.plain, $scope.context.headers);
205+
cleanSchemeMetadata($scope.methodInfo.queryParameters, $scope.context.queryParameters);
204206
});
205207

206208
$scope.cancelRequest = function () {
@@ -309,18 +311,8 @@
309311
}
310312
}
311313

312-
function removeCustomSchemeData(context) {
313-
Object.keys(context.plain).map(function (key) {
314-
var isFromSecurityScheme = context.plain[key].definitions[0].isFromSecurityScheme;
315-
316-
if (isFromSecurityScheme) {
317-
delete context.plain[key];
318-
}
319-
});
320-
}
321-
322314
function updateContextData (type, scheme, collection, context) {
323-
var details = $scope.securitySchemes[scheme].describedBy || {};
315+
var details = jQuery.extend({}, $scope.securitySchemes[scheme].describedBy || {});
324316
var securityHeaders = details[type] || {};
325317

326318
if (securityHeaders) {
@@ -358,8 +350,6 @@
358350
$scope.currentSchemeType = type;
359351
$scope.context.forceRequest = false;
360352

361-
readCustomSchemeInfo(name);
362-
363353
cleanSchemeMetadata($scope.methodInfo.headers.plain, $scope.context.headers);
364354
cleanSchemeMetadata($scope.methodInfo.queryParameters, $scope.context.queryParameters);
365355

0 commit comments

Comments
 (0)