Skip to content

Commit e6ddfb4

Browse files
committed
Merge pull request #105 from mulesoft/bugs/fix-spinner
Fix spinner when making a API request
2 parents f8b37f7 + 76dc9f0 commit e6ddfb4

File tree

7 files changed

+21
-27
lines changed

7 files changed

+21
-27
lines changed

dist/examples/leagues.raml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ securitySchemes:
3434
settings:
3535
authorizationUri: https://github.com/login/oauth/authorize
3636
accessTokenUri: https://github.com/login/oauth/access_token
37-
authorizationGrants: [ code, token ]
37+
authorizationGrants: [ code ]
3838
scopes:
3939
- "user"
4040
- "user:email"

dist/scripts/api-console.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,7 +1143,6 @@
11431143
var segmentContexts = resolveSegementContexts($scope.resource.pathSegments, $scope.context.uriParameters.data());
11441144

11451145
$scope.showSpinner = true;
1146-
// $scope.toggleSidebar($event, true);
11471146
$scope.toggleRequestMetadata($event, true);
11481147

11491148
try {
@@ -5282,11 +5281,9 @@ angular.module('ramlConsoleApp').run(['$templateCache', function($templateCache)
52825281
" <div class=\"raml-console-sidebar-action-group\">\n" +
52835282
" <button ng-hide=\"showSpinner\" type=\"submit\" class=\"raml-console-sidebar-action raml-console-sidebar-action-{{methodInfo.method}}\" ng-click=\"tryIt($event)\" ng-class=\"{'raml-console-sidebar-action-force':context.forceRequest}\"><span ng-if=\"context.forceRequest\">Force</span> {{methodInfo.method.toUpperCase()}}\n" +
52845283
" </button>\n" +
5285-
" <button ng-if=\"showSpinner\" type=\"submit\" class=\"raml-console-sidebar-action raml-console-sidebar-action-{{methodInfo.method}} raml-console-sidebar-action-cancel-request\" ng-click=\"cancelRequest()\">Cancel</button>\n" +
5284+
" <button ng-if=\"showSpinner\" type=\"submit\" class=\"raml-console-sidebar-action raml-console-sidebar-action-{{methodInfo.method}} raml-console-sidebar-action-cancel-request\" ng-click=\"cancelRequest()\">Cancel <div class=\"raml-console-spinner-request\" ng-if=\"showSpinner\">Loading ...</div></button>\n" +
52865285
" <button class=\"raml-console-sidebar-action raml-console-sidebar-action-clear\" ng-click=\"clearFields()\">Clear</button>\n" +
52875286
" <button class=\"raml-console-sidebar-action raml-console-sidebar-action-reset\" ng-click=\"resetFields()\">Reset</button>\n" +
5288-
"\n" +
5289-
" <div class=\"raml-console-spinner-request\" ng-if=\"showSpinner\">Loading ...</div>\n" +
52905287
" </div>\n" +
52915288
" </div>\n" +
52925289
" </section>\n" +

dist/styles/api-console-dark-theme.css

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3848,7 +3848,7 @@ span.raml-console-side-bar-required-field {
38483848

38493849
/*spinner request*/
38503850

3851-
@-webkit-keyframes raml-console-spinner_request {
3851+
@-webkit-keyframes raml-console-spinner-request {
38523852
0% {
38533853
-webkit-transform: rotate(0deg);
38543854
-moz-transform: rotate(0deg);
@@ -3866,7 +3866,7 @@ span.raml-console-side-bar-required-field {
38663866
}
38673867
}
38683868

3869-
@-moz-keyframes raml-console-spinner_request {
3869+
@-moz-keyframes raml-console-spinner-request {
38703870
0% {
38713871
-webkit-transform: rotate(0deg);
38723872
-moz-transform: rotate(0deg);
@@ -3884,7 +3884,7 @@ span.raml-console-side-bar-required-field {
38843884
}
38853885
}
38863886

3887-
@-o-keyframes raml-console-spinner_request {
3887+
@-o-keyframes raml-console-spinner-request {
38883888
0% {
38893889
-webkit-transform: rotate(0deg);
38903890
-moz-transform: rotate(0deg);
@@ -3942,9 +3942,9 @@ span.raml-console-side-bar-required-field {
39423942
height: 1em;
39433943
overflow: hidden;
39443944
text-indent: 100%;
3945-
position: relative;
3946-
left: 153px;
3947-
top: -27px;
3945+
position: absolute;
3946+
left: 125px;
3947+
margin-top: 7px;
39483948
}
39493949

39503950
.raml-console-initializer-container {

dist/styles/api-console-light-theme.css

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3848,7 +3848,7 @@ span.raml-console-side-bar-required-field {
38483848

38493849
/*spinner request*/
38503850

3851-
@-webkit-keyframes raml-console-spinner_request {
3851+
@-webkit-keyframes raml-console-spinner-request {
38523852
0% {
38533853
-webkit-transform: rotate(0deg);
38543854
-moz-transform: rotate(0deg);
@@ -3866,7 +3866,7 @@ span.raml-console-side-bar-required-field {
38663866
}
38673867
}
38683868

3869-
@-moz-keyframes raml-console-spinner_request {
3869+
@-moz-keyframes raml-console-spinner-request {
38703870
0% {
38713871
-webkit-transform: rotate(0deg);
38723872
-moz-transform: rotate(0deg);
@@ -3884,7 +3884,7 @@ span.raml-console-side-bar-required-field {
38843884
}
38853885
}
38863886

3887-
@-o-keyframes raml-console-spinner_request {
3887+
@-o-keyframes raml-console-spinner-request {
38883888
0% {
38893889
-webkit-transform: rotate(0deg);
38903890
-moz-transform: rotate(0deg);
@@ -3942,9 +3942,9 @@ span.raml-console-side-bar-required-field {
39423942
height: 1em;
39433943
overflow: hidden;
39443944
text-indent: 100%;
3945-
position: relative;
3946-
left: 153px;
3947-
top: -27px;
3945+
position: absolute;
3946+
left: 125px;
3947+
margin-top: 7px;
39483948
}
39493949

39503950
.raml-console-initializer-container {

src/app/directives/sidebar.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,6 @@
275275
var segmentContexts = resolveSegementContexts($scope.resource.pathSegments, $scope.context.uriParameters.data());
276276

277277
$scope.showSpinner = true;
278-
// $scope.toggleSidebar($event, true);
279278
$scope.toggleRequestMetadata($event, true);
280279

281280
try {

src/app/directives/sidebar.tpl.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,9 @@ <h4 class="raml-console-sidebar-subhead">Body</h4>
9494
<div class="raml-console-sidebar-action-group">
9595
<button ng-hide="showSpinner" type="submit" class="raml-console-sidebar-action raml-console-sidebar-action-{{methodInfo.method}}" ng-click="tryIt($event)" ng-class="{'raml-console-sidebar-action-force':context.forceRequest}"><span ng-if="context.forceRequest">Force</span> {{methodInfo.method.toUpperCase()}}
9696
</button>
97-
<button ng-if="showSpinner" type="submit" class="raml-console-sidebar-action raml-console-sidebar-action-{{methodInfo.method}} raml-console-sidebar-action-cancel-request" ng-click="cancelRequest()">Cancel</button>
97+
<button ng-if="showSpinner" type="submit" class="raml-console-sidebar-action raml-console-sidebar-action-{{methodInfo.method}} raml-console-sidebar-action-cancel-request" ng-click="cancelRequest()">Cancel <div class="raml-console-spinner-request" ng-if="showSpinner">Loading ...</div></button>
9898
<button class="raml-console-sidebar-action raml-console-sidebar-action-clear" ng-click="clearFields()">Clear</button>
9999
<button class="raml-console-sidebar-action raml-console-sidebar-action-reset" ng-click="resetFields()">Reset</button>
100-
101-
<div class="raml-console-spinner-request" ng-if="showSpinner">Loading ...</div>
102100
</div>
103101
</div>
104102
</section>

src/scss/_spinner.scss

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858

5959

6060
/*spinner request*/
61-
@-webkit-keyframes spinner_request {
61+
@-webkit-keyframes spinner-request {
6262
0% {
6363
-webkit-transform: rotate(0deg);
6464
-moz-transform: rotate(0deg);
@@ -76,7 +76,7 @@
7676
}
7777
}
7878

79-
@-moz-keyframes spinner_request {
79+
@-moz-keyframes spinner-request {
8080
0% {
8181
-webkit-transform: rotate(0deg);
8282
-moz-transform: rotate(0deg);
@@ -94,7 +94,7 @@
9494
}
9595
}
9696

97-
@-o-keyframes spinner_request {
97+
@-o-keyframes spinner-request {
9898
0% {
9999
-webkit-transform: rotate(0deg);
100100
-moz-transform: rotate(0deg);
@@ -151,8 +151,8 @@
151151
height: 1em;
152152
overflow: hidden;
153153
text-indent: 100%;
154-
position: relative;
155-
left: 153px;
156-
top: -27px;
154+
position: absolute;
155+
left: 125px;
156+
margin-top: 7px;
157157
}
158158

0 commit comments

Comments
 (0)