Remove legacy-cli checks

They are all failing right now and will continue to do so forever.

For future versions, this problem should be addressed with a system that
dynamically allows skipping tests once they have been verified as Ok
failures.

See PR stratis-storage/stratis-cli#1091 for
further discussion.

Signed-off-by: mulhern <amulhern@redhat.com>

Author: mulkieran

.github/workflows/nightly.yml

@@ -190,77 +190,6 @@ jobs:
           COMPARE_FEDORA_VERSIONS=./ci/dependency_management/compare_fedora_versions FEDORA_RELEASE=f40 IGNORE_ARGS="--ignore-high=libcryptsetup-rs --ignore-high=libcryptsetup-rs-sys --ignore-high=devicemapper --ignore-high=libblkid-rs" make -f Makefile_dependencies check-fedora-versions
           COMPARE_FEDORA_VERSIONS=./ci/dependency_management/compare_fedora_versions FEDORA_RELEASE=f39 IGNORE_ARGS="--ignore-high=libcryptsetup-rs --ignore-high=libcryptsetup-rs-sys --ignore-high=devicemapper --ignore-high=libblkid-rs" make -f Makefile_dependencies check-fedora-versions
 
-  legacy-cli-checks:
-    continue-on-error: true
-    strategy:
-      matrix:
-        include:
-          - image: fedora:36  # PINNED DEVELOPMENT ENVIRONMENT
-            tag: v3.4.1
-          - image: fedora:36  # PINNED DEVELOPMENT ENVIRONMENT
-            tag: v3.4.0
-          - image: fedora:36  # PINNED DEVELOPMENT ENVIRONMENT
-            tag: v3.3.0
-          - image: fedora:35  # PINNED DEVELOPMENT ENVIRONMENT
-            tag: v3.2.0
-          - image: fedora:35  # PINNED DEVELOPMENT ENVIRONMENT
-            tag: v3.1.0
-          - image: fedora:35  # PINNED DEVELOPMENT ENVIRONMENT
-            tag: v3.0.0
-          - image: fedora:35  # PINNED DEVELOPMENT ENVIRONMENT
-            tag: v3.0.1
-    runs-on: ubuntu-22.04
-    container:
-      image: ${{ matrix.image }}
-      options: --privileged --userns=host --ipc=host -v /run/dbus/system_bus_socket:/run/dbus/system_bus_socket:ro -v /usr/share/dbus-1:/usr/share/dbus-1
-    steps:
-      - uses: actions/checkout@v4
-      - name: Install dependencies for Fedora
-        run: >
-          dnf install -y
-          asciidoc
-          clang
-          cryptsetup-devel
-          dbus-devel
-          device-mapper-devel
-          libblkid-devel
-          git
-          glibc-static
-          make
-          ncurses
-          python3-coverage
-          python3-dbus-client-gen
-          python3-dbus-python-client-gen
-          python3-justbytes
-          python3-dateutil
-          python3-packaging
-          python3-psutil
-          python3-wcwidth
-          systemd-devel
-      - uses: dtolnay/rust-toolchain@master
-        with:
-          components: cargo
-          toolchain: 1.80.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
-      - name: Build stratisd
-        run: PROFILEDIR=debug make -f Makefile build-all
-      - name: Install stratisd
-        run: PROFILEDIR=debug make -f Makefile install
-      - name: Workaround for dbus inotify
-        run: cp stratisd.conf /usr/share/dbus-1/system.d
-      - name: Check out stratis-cli
-        run: git clone https://github.com/stratis-storage/stratis-cli.git
-      - name: Checkout tag
-        run: git checkout tags/${{ matrix.tag }} -b ${{ matrix.tag }}
-        working-directory: ./stratis-cli
-      - name: Run stratis-cli tests
-        run: >
-          RUST_LOG=stratisd=debug
-          STRATISD=/usr/libexec/stratisd
-          STRATIS_SKIP_UNSTABLE_TEST=1
-          PYTHONPATH=./src
-          make dbus-tests
-        working-directory: ./stratis-cli
-
   python-based-tests:
     strategy:
       matrix: