Skip to content

Commit 5c2e0a0

Browse files
authored
♻️ Feat: remove custom date converter (#113)
1 parent 2e9f67d commit 5c2e0a0

File tree

1 file changed

+1
-25
lines changed

1 file changed

+1
-25
lines changed

pkg/plugin/plugin.go

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
"github.com/grafana/grafana-plugin-sdk-go/data"
1616
"github.com/grafana/grafana-plugin-sdk-go/data/sqlutil"
1717
"github.com/mullerpeter/databricks-grafana/pkg/integrations"
18-
"reflect"
1918
"strconv"
2019
"strings"
2120
"time"
@@ -397,30 +396,7 @@ func (d *Datasource) query(ctx context.Context, pCtx backend.PluginContext, quer
397396
return response
398397
}
399398

400-
dateConverter := sqlutil.Converter{
401-
Name: "Databricks date to timestamp converter",
402-
InputScanType: reflect.TypeOf(sql.NullString{}),
403-
InputTypeName: "DATE",
404-
FrameConverter: sqlutil.FrameConverter{
405-
FieldType: data.FieldTypeNullableTime,
406-
ConverterFunc: func(n interface{}) (interface{}, error) {
407-
v := n.(*sql.NullString)
408-
409-
if !v.Valid {
410-
return (*time.Time)(nil), nil
411-
}
412-
413-
f := v.String
414-
date, error := time.Parse("2006-01-02", f)
415-
if error != nil {
416-
return (*time.Time)(nil), error
417-
}
418-
return &date, nil
419-
},
420-
},
421-
}
422-
423-
frame, err = sqlutil.FrameFromRows(rows, -1, dateConverter)
399+
frame, err = sqlutil.FrameFromRows(rows, -1)
424400
if err != nil {
425401
log.DefaultLogger.Info("FrameFromRows", "err", err)
426402
response.Error = err

0 commit comments

Comments
 (0)