Remove remainders of AddressCache

Author: acb-mv

ios/MullvadREST/ApiHandlers/AddressCache.swift

@@ -13,7 +13,7 @@ import MullvadTypes
 extension REST {
     /// The API hostname and endpoint are defined in the Info.plist of the MullvadREST framework bundle
     /// This is due to not being able to target `Bundle.main` from a Unit Test environment as it gets its own bundle that would not contain the above variables.
-    nonisolated(unsafe) private static let infoDictionary = Bundle(for: AddressCache.self).infoDictionary!
+    nonisolated(unsafe) private static let infoDictionary = Bundle(for: ProxyFactory.self).infoDictionary!
 
     /// Default API hostname.
     public static let defaultAPIHostname = infoDictionary["ApiHostName"] as! String

ios/MullvadREST/ApiHandlers/RESTDefaults.swift

@@ -10,16 +10,15 @@ import Foundation
 import Network
 
 extension REST {
-    public static func makeURLSession(addressCache: AddressCache) -> URLSession {
+    public static func makeURLSession() -> URLSession {
         let certificatePath = Bundle(for: SSLPinningURLSessionDelegate.self)
             .path(forResource: "le_root_cert", ofType: "cer")!
         let data = FileManager.default.contents(atPath: certificatePath)!
         let secCertificate = SecCertificateCreateWithData(nil, data as CFData)!
 
         let sessionDelegate = SSLPinningURLSessionDelegate(
             sslHostname: defaultAPIHostname,
-            trustedRootCertificates: [secCertificate],
-            addressCache: addressCache
+            trustedRootCertificates: [secCertificate]
         )
 
         let sessionConfiguration = URLSessionConfiguration.ephemeral

ios/MullvadREST/ApiHandlers/RESTURLSession.swift

@@ -14,14 +14,12 @@ import Security
 final class SSLPinningURLSessionDelegate: NSObject, URLSessionDelegate, @unchecked Sendable {
     private let sslHostname: String
     private let trustedRootCertificates: [SecCertificate]
-    private let addressCache: REST.AddressCache
 
     private let logger = Logger(label: "SSLPinningURLSessionDelegate")
 
-    init(sslHostname: String, trustedRootCertificates: [SecCertificate], addressCache: REST.AddressCache) {
+    init(sslHostname: String, trustedRootCertificates: [SecCertificate]) {
         self.sslHostname = sslHostname
         self.trustedRootCertificates = trustedRootCertificates
-        self.addressCache = addressCache
     }
 
     // MARK: - URLSessionDelegate
@@ -39,13 +37,9 @@ final class SSLPinningURLSessionDelegate: NSObject, URLSessionDelegate, @uncheck
             /// The same goes for direct connections to the API, the host would be the IP address of the endpoint.
             /// Certificates, cannot be signed for IP addresses, in such case, specify that the host name is `defaultAPIHostname`
             var hostName = challenge.protectionSpace.host
-            let overridenHostnames = [
-                "\(IPv4Address.loopback)",
-                "\(IPv6Address.loopback)",
-                "\(REST.defaultAPIEndpoint.ip)",
-                "\(addressCache.getCurrentEndpoint().ip)",
-            ]
-            if overridenHostnames.contains(hostName) {
+            // this used to check for the current endpoint in the address cache as well, though this has been deprecated.
+            
+            if hostName == "\(REST.defaultAPIEndpoint.ip)" {
                 hostName = sslHostname
             }
 

ios/MullvadREST/ApiHandlers/SSLPinningURLSessionDelegate.swift

@@ -19,7 +19,6 @@ import XCTest
 
 class MullvadApiTests: XCTestCase {
     let encoder = JSONEncoder()
-    let addressCache = REST.AddressCache(canWriteToCache: false, fileCache: MemoryCache())
 
     func makeApiProxy(port: UInt16) throws -> APIQuerying {
         let shadowsocksLoader = ShadowsocksLoaderStub(
@@ -43,7 +42,6 @@ class MullvadApiTests: XCTestCase {
                     accessMethodsRepository
                     .fetchAll()
             ),
-            addressCacheProvider: addressCache,
             accessMethodChangeListeners: []
         )