Add extra logging and fix comments

Author: pinkisemils

ios/MullvadREST/MullvadAPI/MullvadApiNetworkOperation.swift

@@ -79,7 +79,10 @@ extension REST {
                     logger.debug("\(#function): \(request.name) API response received")
 
                     if let apiError = response.error {
-                        logger.error("Request failed to send error=\(apiError)")
+                        logger
+                            .error(
+                                "Response contained error code \(apiError.statusCode), error: \(apiError.errorDescription)"
+                            )
                         finish(result: .failure(restError(apiError: apiError)))
                         return
                     }

ios/MullvadVPNUITests/MullvadApi.swift

@@ -7,6 +7,7 @@
 //
 
 import Foundation
+import MullvadLogging
 import MullvadRustRuntime
 
 struct MullvadApiError: Error {
@@ -29,7 +30,10 @@ private struct DeviceResponse: Decodable {
 class MullvadApi {
     private let context: SwiftApiContext
 
+    private static let logger = Logger(label: "MullvadApi")
+
     init(apiAddress: String, hostname: String) throws {
+        Self.logger.debug("Initializing MullvadApi with address: \(apiAddress), hostname: \(hostname)")
         let directRaw = convert_builtin_access_method_setting(
             UUID().uuidString, "Direct", true, UInt8(KindDirect.rawValue), nil
         )

ios/MullvadVPNUITests/Networking/MullvadAPIWrapper.swift

@@ -8,6 +8,7 @@
 
 import CryptoKit
 import Foundation
+import MullvadRustRuntime
 import XCTest
 
 enum MullvadAPIError: Error {
@@ -32,6 +33,7 @@ class MullvadAPIWrapper: @unchecked Sendable {
         .infoDictionary?["ApiEndpoint"] as! String
 
     init() throws {
+        RustLogging.initialize()
         let apiAddress = try Self.getAPIIPAddress() + ":" + Self.getAPIPort()
         let hostname = Self.hostName
         mullvadAPI = try MullvadApi(apiAddress: apiAddress, hostname: hostname)

mullvad-ios/src/api_client/access_method_settings.rs

@@ -155,16 +155,16 @@ pub unsafe extern "C" fn init_access_method_settings_wrapper(
 /// This takes ownership of the `AccessMethodSetting`s pointed to by `raw_array`. So the memory is
 /// freed when the returned vector is dropped.
 ///
-/// SAFETY: `raw_array` must be aligned, non-null, initialized for `count` reads and not be used
-/// after this call.
+/// SAFETY: `raw_array` must be aligned, initialized for `count` reads and not be used after this
+/// call.
 unsafe fn access_methods_from_raw_array(
     raw_array: *const *mut AccessMethodSetting,
     number_of_elements: usize,
 ) -> Vec<AccessMethodSetting> {
     // `slice::from_raw_parts` will dereference the null pointer even if the slice is empty.
     // In that case, just return an empty vec.
     if number_of_elements == 0 || raw_array.is_null() {
-        return vec![]
+        return vec![];
     }
     // SAFETY: See notice above
     let slice = unsafe { slice::from_raw_parts(raw_array, number_of_elements) };