Skip to content

Commit 56ca5ec

Browse files
authored
Merge pull request #17 from Noisyfox/moe-sdk-j8support
(multi-os-engine/multi-os-engine#179) Don't add java8support jar to m…
2 parents 4601d50 + 4acd2d9 commit 56ca5ec

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

src/main/java/org/moe/gradle/AbstractMoePlugin.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -380,15 +380,6 @@ protected void installCommonDependencies() {
380380
}
381381
project.getDependencies().add(JavaPlugin.TEST_IMPLEMENTATION_CONFIGURATION_NAME,
382382
FileUtils.getNameAsArtifact(getSDK().getiOSJUnitJar(), getSDK().sdkVersion));
383-
384-
// Install java 8 support jars to fix lambda compilation
385-
project.getDependencies().add(
386-
isLibrary ? JavaPlugin.API_CONFIGURATION_NAME : JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME,
387-
FileUtils.getNameAsArtifact(getSDK().getJava8SupportJar(), getSDK().sdkVersion)
388-
);
389-
390-
project.getDependencies().add(JavaPlugin.TEST_IMPLEMENTATION_CONFIGURATION_NAME,
391-
FileUtils.getNameAsArtifact(getSDK().getJava8SupportJar(), getSDK().sdkVersion));
392383
}
393384

394385
abstract protected void checkRemoteServer(AbstractBaseTask task);

src/main/java/org/moe/gradle/MoePlugin.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,17 @@
2222
import org.gradle.api.Task;
2323
import org.gradle.api.logging.Logger;
2424
import org.gradle.api.logging.Logging;
25+
import org.gradle.api.plugins.JavaPlugin;
2526
import org.gradle.internal.reflect.Instantiator;
2627
import org.gradle.tooling.provider.model.ToolingModelBuilderRegistry;
2728
import org.moe.gradle.anns.NotNull;
2829
import org.moe.gradle.anns.Nullable;
2930
import org.moe.gradle.remote.Server;
3031
import org.moe.gradle.tasks.AbstractBaseTask;
32+
import org.moe.gradle.tasks.ClassValidate;
3133
import org.moe.gradle.tasks.Desugar;
3234
import org.moe.gradle.tasks.Dex;
3335
import org.moe.gradle.tasks.Dex2Oat;
34-
import org.moe.gradle.tasks.ClassValidate;
3536
import org.moe.gradle.tasks.GenerateUIObjCInterfaces;
3637
import org.moe.gradle.tasks.IpaBuild;
3738
import org.moe.gradle.tasks.Launchers;
@@ -45,6 +46,7 @@
4546
import org.moe.gradle.tasks.XcodeInternal;
4647
import org.moe.gradle.tasks.XcodeProvider;
4748
import org.moe.gradle.utils.Arch;
49+
import org.moe.gradle.utils.FileUtils;
4850
import org.moe.gradle.utils.PropertiesUtil;
4951
import org.moe.gradle.utils.Require;
5052

@@ -135,6 +137,14 @@ public void apply(Project project) {
135137
// Add common MOE dependencies
136138
installCommonDependencies();
137139

140+
// Install java 8 support jars to fix lambda compilation
141+
project.getDependencies().add(JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME,
142+
FileUtils.getNameAsArtifact(getSDK().getJava8SupportJar(), getSDK().sdkVersion)
143+
);
144+
145+
project.getDependencies().add(JavaPlugin.TEST_IMPLEMENTATION_CONFIGURATION_NAME,
146+
FileUtils.getNameAsArtifact(getSDK().getJava8SupportJar(), getSDK().sdkVersion));
147+
138148
// Install rules
139149
addRule(ProGuard.class, "Creates a ProGuarded jar.",
140150
asList(SOURCE_SET, MODE), MoePlugin.this);

0 commit comments

Comments
 (0)