Skip to content

Commit 83b3ca0

Browse files
committed
(multi-os-engine/multi-os-engine#147) Replace retrolambda with classvalidator
1 parent 1de883f commit 83b3ca0

File tree

10 files changed

+128
-301
lines changed

10 files changed

+128
-301
lines changed

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ dependencies {
7575
included project(':moe.tools.common')
7676
included project(':moe.document.pbxproj')
7777
included project(':moe.generator.project')
78+
included project(':moe.tools.classvalidator')
7879

7980
testCompile group: 'junit', name: 'junit', version: '4.12'
8081
testCompile gradleTestKit()

src/main/java/org/moe/gradle/MoePlugin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@
3030
import org.moe.gradle.tasks.AbstractBaseTask;
3131
import org.moe.gradle.tasks.Dex;
3232
import org.moe.gradle.tasks.Dex2Oat;
33+
import org.moe.gradle.tasks.ClassValidate;
3334
import org.moe.gradle.tasks.GenerateUIObjCInterfaces;
3435
import org.moe.gradle.tasks.IpaBuild;
3536
import org.moe.gradle.tasks.Launchers;
3637
import org.moe.gradle.tasks.NatJGen;
3738
import org.moe.gradle.tasks.ProGuard;
3839
import org.moe.gradle.tasks.ResourcePackager;
39-
import org.moe.gradle.tasks.Retrolambda;
4040
import org.moe.gradle.tasks.StartupProvider;
4141
import org.moe.gradle.tasks.TestClassesProvider;
4242
import org.moe.gradle.tasks.UpdateXcodeSettings;
@@ -137,7 +137,7 @@ public void apply(Project project) {
137137
// Install rules
138138
addRule(ProGuard.class, "Creates a ProGuarded jar.",
139139
asList(SOURCE_SET, MODE), MoePlugin.this);
140-
addRule(Retrolambda.class, "Creates a Retrolambda-d jar.",
140+
addRule(ClassValidate.class, "Validate classes.",
141141
asList(SOURCE_SET, MODE), MoePlugin.this);
142142
addRule(Dex.class, "Creates a Dexed jar.",
143143
asList(SOURCE_SET, MODE), MoePlugin.this);

src/main/java/org/moe/gradle/MoeSDK.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,6 @@ private void validateSDK(@NotNull Path path, boolean isLocalSDK) {
378378
validate(FIL, path, "tools/proguard-full.cfg");
379379
validate(FIL, path, "tools/proguard.cfg");
380380
validate(FIL, path, "tools/proguard.jar");
381-
validate(FIL, path, "tools/retrolambda.jar");
382381
validate(DIR, path, "tools/windows/x86_64");
383382
validate(FIL, path, "tools/wrapnatjgen.jar");
384383
validate(FIL, path, "tools/gradlew.zip");
@@ -432,7 +431,6 @@ private void validate(int type, @NotNull Path path, @NotNull String sub) throws
432431
private @Nullable File MOE_SDK_PROGUARDFULL_CFG;
433432
private @Nullable File MOE_SDK_PROGUARD_CFG;
434433
private @Nullable File MOE_SDK_PROGUARD_JAR;
435-
private @Nullable File MOE_SDK_RETROLAMBDA_JAR;
436434
private @Nullable File MOE_SDK_WINDOWS_X86_64_SUPPORT;
437435
private @Nullable File MOE_SDK_NATJGEN_JAR;
438436
private @Nullable File MOE_SDK_GRADLEW_ZIP;
@@ -462,7 +460,6 @@ private void bakeSDKPaths(@NotNull Path path) {
462460
MOE_SDK_PROGUARDFULL_CFG = path.resolve("tools/proguard-full.cfg").toFile();
463461
MOE_SDK_PROGUARD_CFG = path.resolve("tools/proguard.cfg").toFile();
464462
MOE_SDK_PROGUARD_JAR = path.resolve("tools/proguard.jar").toFile();
465-
MOE_SDK_RETROLAMBDA_JAR = path.resolve("tools/retrolambda.jar").toFile();
466463
MOE_SDK_WINDOWS_X86_64_SUPPORT = path.resolve("tools/windows/x86_64").toFile();
467464
MOE_SDK_NATJGEN_JAR = path.resolve("tools/wrapnatjgen.jar").toFile();
468465
MOE_SDK_GRADLEW_ZIP = path.resolve("tools/gradlew.zip").toFile();
@@ -597,11 +594,6 @@ public File getProGuardJar() {
597594
return safeVariable(MOE_SDK_PROGUARD_JAR, "MOE_SDK_PROGUARD_JAR");
598595
}
599596

600-
@NotNull
601-
public File getRetrolambdaJar() {
602-
return safeVariable(MOE_SDK_RETROLAMBDA_JAR, "MOE_SDK_RETROLAMBDA_JAR");
603-
}
604-
605597
@NotNull
606598
@IgnoreUnused
607599
public File getWindows_X86_64Support() {

src/main/java/org/moe/gradle/tasks/AbstractBaseTask.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.gradle.process.ExecResult;
2727
import org.gradle.process.ExecSpec;
2828
import org.gradle.process.JavaExecSpec;
29+
import org.moe.common.utils.FileUtilsKt;
2930
import org.moe.gradle.*;
3031
import org.moe.gradle.anns.IgnoreUnused;
3132
import org.moe.gradle.anns.NotNull;
@@ -188,7 +189,7 @@ private boolean shouldLogOnExecFail() {
188189
protected void exec(@NotNull Action<ExecSpec> spec) {
189190
Require.nonNull(spec);
190191

191-
FileUtils.createEmpty(getLogFile());
192+
FileUtilsKt.touch(getLogFile());
192193

193194
final ExecResult result = getProject().exec(execSpec -> {
194195
// Pre-configure
@@ -222,7 +223,7 @@ protected void exec(@NotNull Action<ExecSpec> spec) {
222223
protected void javaexec(@NotNull Action<JavaExecSpec> spec) {
223224
Require.nonNull(spec);
224225

225-
FileUtils.createEmpty(getLogFile());
226+
FileUtilsKt.touch(getLogFile());
226227

227228
final ExecResult result = getProject().javaexec(execSpec -> {
228229
execSpec.jvmArgs(getExtension().javaProcess.getJvmArgs());

src/main/java/org/moe/gradle/tasks/Dex.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -144,12 +144,12 @@ private List<String> prepareArgumentsList() {
144144
return args;
145145
}
146146

147-
private Retrolambda retrolambdaTaskDep;
147+
private ClassValidate classValidateTaskDep;
148148

149149
@NotNull
150150
@Internal
151-
public Retrolambda getRetrolambdaTaskDep() {
152-
return Require.nonNull(retrolambdaTaskDep);
151+
public ClassValidate getClassValidateTaskDep() {
152+
return Require.nonNull(classValidateTaskDep);
153153
}
154154

155155
protected final void setupMoeTask(@NotNull SourceSet sourceSet, final @NotNull Mode mode) {
@@ -165,15 +165,15 @@ protected final void setupMoeTask(@NotNull SourceSet sourceSet, final @NotNull M
165165
setDescription("Generates dex files (sourceset: " + sourceSet.getName() + ", mode: " + mode.name + ").");
166166

167167
// Add dependencies
168-
final Retrolambda retroTask = getMoePlugin().getTaskBy(Retrolambda.class, sourceSet, mode);
169-
retrolambdaTaskDep = retroTask;
170-
dependsOn(retroTask);
168+
final ClassValidate classValidate = getMoePlugin().getTaskBy(ClassValidate.class, sourceSet, mode);
169+
classValidateTaskDep = classValidate;
170+
dependsOn(classValidate);
171171

172172
// Update convention mapping
173173
addConvention(CONVENTION_DX_JAR, sdk::getDxJar);
174174
addConvention(CONVENTION_INPUT_FILES, () -> {
175175
final ArrayList<Object> files = new ArrayList<>();
176-
files.add(retroTask.getOutputDir());
176+
files.add(classValidate.getClassesOutputDir());
177177
return files;
178178

179179
});

src/main/java/org/moe/gradle/tasks/GenerateUIObjCInterfaces.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -233,14 +233,6 @@ protected void run() {
233233
}
234234
}
235235

236-
private Retrolambda retrolambdaTaskDep;
237-
238-
@NotNull
239-
@Internal
240-
public Retrolambda getRetrolambdaTaskDep() {
241-
return Require.nonNull(retrolambdaTaskDep);
242-
}
243-
244236
protected final void setupMoeTask(final @NotNull Mode mode) {
245237
SourceSet sourceSet = TaskUtils.getSourceSet(getMoePlugin(), SourceSet.MAIN_SOURCE_SET_NAME);
246238
Require.nonNull(sourceSet);
@@ -253,14 +245,13 @@ protected final void setupMoeTask(final @NotNull Mode mode) {
253245
setDescription("Generates header files for Interface Builder");
254246

255247
// Add dependencies
256-
final Retrolambda retroTask = getMoePlugin().getTaskBy(Retrolambda.class, sourceSet, mode);
257-
retrolambdaTaskDep = retroTask;
258-
dependsOn(retroTask);
248+
final ProGuard proguardTask = getMoePlugin().getTaskBy(ProGuard.class, sourceSet, mode);
249+
dependsOn(proguardTask);
259250

260251
// Update convention mapping
261252
addConvention(CONVENTION_INPUT_FILES, () -> {
262253
final ArrayList<Object> files = new ArrayList<>();
263-
files.add(retroTask.getOutputDir());
254+
files.add(proguardTask.getOutJar());
264255
if (getMoeExtension().proguard.getLevelRaw() == ProGuardOptions.LEVEL_APP) {
265256
files.add(getMoeExtension().getPlatformJar());
266257
}

0 commit comments

Comments
 (0)