Skip to content

Commit 823b45f

Browse files
authored
docs: fix dnsaddrResolver name (#392)
Fixes documentation errors and adds doc-check to prevent regressions. Fixes #388
1 parent d4164fb commit 823b45f

File tree

7 files changed

+16
-63
lines changed

7 files changed

+16
-63
lines changed

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,8 @@ A standard way to represent addresses that
3535

3636
```TypeScript
3737
import { multiaddr } from '@multiformats/multiaddr'
38-
const addr = multiaddr("/ip4/127.0.0.1/udp/1234")
39-
// Multiaddr(/ip4/127.0.0.1/udp/1234)
4038

41-
const addr = multiaddr("/ip4/127.0.0.1/udp/1234")
39+
const addr = multiaddr('/ip4/127.0.0.1/udp/1234')
4240
// Multiaddr(/ip4/127.0.0.1/udp/1234)
4341

4442
addr.bytes
@@ -77,9 +75,9 @@ DNSADDR addresses can resolve to multiple multiaddrs, since there is no limit to
7775

7876
```TypeScript
7977
import { multiaddr, resolvers } from '@multiformats/multiaddr'
80-
import { dnsaddr } from '@multiformats/multiaddr/resolvers'
78+
import { dnsaddrResolver } from '@multiformats/multiaddr/resolvers'
8179

82-
resolvers.set('dnsaddr', dnsaddr)
80+
resolvers.set('dnsaddr', dnsaddrResolver)
8381

8482
const ma = multiaddr('/dnsaddr/bootstrap.libp2p.io')
8583

@@ -88,7 +86,7 @@ const resolved = await ma.resolve({
8886
signal: AbortSignal.timeout(5000)
8987
})
9088

91-
console.info(await ma.resolve(resolved)
89+
console.info(resolved)
9290
// [Multiaddr('/ip4/147.75...'), Multiaddr('/ip4/147.75...'), Multiaddr('/ip4/147.75...')...]
9391
```
9492

@@ -102,7 +100,9 @@ import { dns } from '@multiformats/dns'
102100
import { dnsJsonOverHttps } from '@multiformats/dns/resolvers'
103101

104102
const resolver = dns({
105-
'.': dnsJsonOverHttps('https://cloudflare-dns.com/dns-query')
103+
resolvers: {
104+
'.': dnsJsonOverHttps('https://cloudflare-dns.com/dns-query')
105+
}
106106
})
107107

108108
const ma = multiaddr('/dnsaddr/bootstrap.libp2p.io')

examples/try.js

Lines changed: 0 additions & 29 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@
154154
"clean": "aegir clean",
155155
"lint": "aegir lint",
156156
"dep-check": "aegir dep-check",
157+
"doc-check": "aegir doc-check",
157158
"build": "aegir build",
158159
"test": "aegir test -f",
159160
"test:chrome": "aegir test -t browser --cov",

src/convert.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
/**
2-
* @packageDocumentation
3-
*
4-
* Provides methods for converting
5-
*/
6-
71
import { IpNet } from '@chainsafe/netmask'
82
import { base32 } from 'multiformats/bases/base32'
93
import { base58btc } from 'multiformats/bases/base58'

src/index.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@
1313
*
1414
* ```TypeScript
1515
* import { multiaddr } from '@multiformats/multiaddr'
16-
* const addr = multiaddr("/ip4/127.0.0.1/udp/1234")
17-
* // Multiaddr(/ip4/127.0.0.1/udp/1234)
1816
*
19-
* const addr = multiaddr("/ip4/127.0.0.1/udp/1234")
17+
* const addr = multiaddr('/ip4/127.0.0.1/udp/1234')
2018
* // Multiaddr(/ip4/127.0.0.1/udp/1234)
2119
*
2220
* addr.bytes
@@ -55,9 +53,9 @@
5553
*
5654
* ```TypeScript
5755
* import { multiaddr, resolvers } from '@multiformats/multiaddr'
58-
* import { dnsaddr } from '@multiformats/multiaddr/resolvers'
56+
* import { dnsaddrResolver } from '@multiformats/multiaddr/resolvers'
5957
*
60-
* resolvers.set('dnsaddr', dnsaddr)
58+
* resolvers.set('dnsaddr', dnsaddrResolver)
6159
*
6260
* const ma = multiaddr('/dnsaddr/bootstrap.libp2p.io')
6361
*
@@ -66,7 +64,7 @@
6664
* signal: AbortSignal.timeout(5000)
6765
* })
6866
*
69-
* console.info(await ma.resolve(resolved)
67+
* console.info(resolved)
7068
* // [Multiaddr('/ip4/147.75...'), Multiaddr('/ip4/147.75...'), Multiaddr('/ip4/147.75...')...]
7169
* ```
7270
*
@@ -80,7 +78,9 @@
8078
* import { dnsJsonOverHttps } from '@multiformats/dns/resolvers'
8179
*
8280
* const resolver = dns({
83-
* '.': dnsJsonOverHttps('https://cloudflare-dns.com/dns-query')
81+
* resolvers: {
82+
* '.': dnsJsonOverHttps('https://cloudflare-dns.com/dns-query')
83+
* }
8484
* })
8585
*
8686
* const ma = multiaddr('/dnsaddr/bootstrap.libp2p.io')

src/multiaddr.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,3 @@
1-
/**
2-
* @packageDocumentation
3-
*
4-
* An implementation of a Multiaddr in JavaScript
5-
*
6-
* @example
7-
*
8-
* ```js
9-
* import { multiaddr } from '@multiformats/multiaddr'
10-
*
11-
* const ma = multiaddr('/ip4/127.0.0.1/tcp/1234')
12-
* ```
13-
*/
14-
151
import { base58btc } from 'multiformats/bases/base58'
162
import { CID } from 'multiformats/cid'
173
import { equals as uint8ArrayEquals } from 'uint8arrays/equals'

src/resolvers/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ export interface Resolver<ResolveOptions extends AbortOptions = AbortOptions> {
55
}
66

77
export { dnsaddrResolver } from './dnsaddr.js'
8+
export type { DNSADDROptions } from './dnsaddr.js'

0 commit comments

Comments
 (0)