Skip to content

Commit 70cd8ce

Browse files
committed
fix: remove unecessary ImplicitSha256Digest
1 parent b7aa2a6 commit 70cd8ce

File tree

2 files changed

+3
-34
lines changed

2 files changed

+3
-34
lines changed

src/cid.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export class CID {
8787
throw new Error('Cannot convert non sha2-256 multihash CID to CIDv0')
8888
}
8989

90-
return createV0(Digest.decodeImplicitSha256(digest), this)
90+
return createV0(Digest.decode(digest), this)
9191
}
9292
}
9393
}
@@ -317,7 +317,7 @@ export const decode = (cid, config) => {
317317
switch (version) {
318318
// CIDv0
319319
case 18: {
320-
const multihash = Digest.decodeImplicitSha256(cid)
320+
const multihash = Digest.decode(cid)
321321
return createV0(multihash, config)
322322
}
323323
// CIDv1
@@ -362,9 +362,7 @@ export const asCID = (value, config) => {
362362
// symbol we still rebase it to the this `CID` implementation by
363363
// delegating that to a constructor.
364364
const { version, multihash, code } = value
365-
const digest = version === 0
366-
? Digest.decodeImplicitSha256(multihash)
367-
: Digest.decode(multihash)
365+
const digest = Digest.decode(multihash)
368366
return create(version, code, digest, config)
369367
} else {
370368
// Otherwise value is not a CID (or an incompatible version of it) in

src/hashes/digest.js

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,6 @@ export const decode = (multihash) => {
4040
return new Digest(code, size, digest, bytes)
4141
}
4242

43-
/**
44-
* Turns bytes representation of multihash digest into an instance.
45-
* @param {Uint8Array} hash
46-
*/
47-
export const decodeImplicitSha256 = (hash) => {
48-
if (hash.byteLength !== SHA256_SIZE) {
49-
throw new Error('Given hash has incorrect length')
50-
}
51-
52-
return new ImplicitSha256Digest(hash)
53-
}
54-
5543
/**
5644
* @param {MultihashDigest} a
5745
* @param {MultihashDigest} b
@@ -65,9 +53,6 @@ export const equals = (a, b) => {
6553
}
6654
}
6755

68-
const SHA256_SIZE = 32
69-
const SHA256_CODE = 0x12
70-
7156
/**
7257
* @typedef {import('./interface').MultihashDigest} MultihashDigest
7358
*/
@@ -95,17 +80,3 @@ export class Digest {
9580
this.bytes = bytes
9681
}
9782
}
98-
99-
/**
100-
* @class
101-
* @implements {MultihashDigest}
102-
* @extends {Digest<0x12, 32>}
103-
*/
104-
class ImplicitSha256Digest extends Digest {
105-
/**
106-
* @param {Uint8Array} digest
107-
*/
108-
constructor (digest) {
109-
super(SHA256_CODE, SHA256_SIZE, digest, digest)
110-
}
111-
}

0 commit comments

Comments
 (0)