fix: additional lint items from Link interface work

Author: rvagg

src/block.js

@@ -94,7 +94,7 @@ function * tree (source, base) {
  * @template T
  * @param {T} source
  * @param {string[]} path
- * @return {API.BlockCursorView<unknown>}
+ * @returns {API.BlockCursorView<unknown>}
  */
 function get (source, path) {
   let node = /** @type {Record<string, any>} */(source)
@@ -153,7 +153,7 @@ class Block {
   /**
    *
    * @param {string} [path]
-   * @return {API.BlockCursorView<unknown>}
+   * @returns {API.BlockCursorView<unknown>}
    */
   get (path = '/') {
     return get(this.value, path.split('/').filter(Boolean))

src/block/interface.ts

@@ -1,7 +1,7 @@
 /* eslint-disable @typescript-eslint/no-unnecessary-type-constraint */
 /* eslint-disable no-use-before-define */
 import { Link, Version } from '../link/interface.js'
-import { CID } from "../cid.js"
+import { CID } from '../cid.js'
 
 /**
  * A byte-encoded representation of some type of `Data`.
@@ -14,6 +14,8 @@ import { CID } from "../cid.js"
  */
 export interface ByteView<Data> extends Uint8Array, Phantom<Data> {}
 
+declare const Marker: unique symbol
+
 /**
  * A utility type to retain an unused type parameter `T`.
  * Similar to [phantom type parameters in Rust](https://doc.rust-lang.org/rust-by-example/generics/phantom.html).
@@ -32,7 +34,6 @@ export interface Phantom<T> {
   // type contstraint.
   [Marker]?: T
 }
-declare const Marker: unique symbol
 
 /**
  * Represents an IPLD block (including its CID) that can be decoded to data of
@@ -66,7 +67,7 @@ export interface BlockView<
   cid: CID<T, C, A, V>
   value: T
 
-  links(): Iterable<[string, CID]>
-  tree(): Iterable<string>
-  get(path:string): BlockCursorView<unknown>
+  links: () => Iterable<[string, CID]>
+  tree: () => Iterable<string>
+  get: (path: string) => BlockCursorView<unknown>
 }

src/cid.js

@@ -35,7 +35,7 @@ export const format = (link, base) => {
   }
 }
 
-/**  @type {WeakMap<API.UnknownLink, Map<string, string>>} */
+/** @type {WeakMap<API.UnknownLink, Map<string, string>>} */
 const cache = new WeakMap()
 
 /**
@@ -174,7 +174,7 @@ export class CID {
    * @template {API.Version} Version
    * @param {API.Link<Data, Format, Alg, Version>} self
    * @param {unknown} other
-   * @returns {other is cid}
+   * @returns {other is CID}
    */
   static equals (self, other) {
     const unknown =

src/hashes/digest.js

@@ -27,7 +27,7 @@ export const create = (code, digest) => {
  * @param {Uint8Array} multihash
  * @returns {MultihashDigest}
  */
-export const decode = multihash => {
+export const decode = (multihash) => {
   const bytes = coerce(multihash)
   const [code, sizeOffset] = varint.decode(bytes)
   const [size, digestOffset] = varint.decode(bytes.subarray(sizeOffset))
@@ -49,9 +49,7 @@ export const equals = (a, b) => {
   if (a === b) {
     return true
   } else {
-    const data = /** @type {{code?:unknown, size?:unknown, bytes?:unknown}} */ (
-      b
-    )
+    const data = /** @type {{code?:unknown, size?:unknown, bytes?:unknown}} */(b)
 
     return (
       a.code === data.code &&

src/link/interface.ts

@@ -4,7 +4,6 @@ import type { MultihashDigest } from '../hashes/interface'
 import type { MultibaseEncoder, MultibaseDecoder, Multibase } from '../bases/interface'
 import type { Phantom, ByteView } from '../block/interface'
 
-
 export type { MultihashDigest, MultibaseEncoder, MultibaseDecoder }
 export type Version = 0 | 1
 
@@ -33,14 +32,13 @@ export interface Link<
   readonly byteLength: number
   readonly bytes: ByteView<Link<Data, Format, Alg, V>>
 
+  equals: (other: unknown) => other is Link<Data, Format, Alg, Version>
 
-  equals(other: unknown): other is Link<Data, Format, Alg, Version>
-
-  toString<Prefix extends string>(base?: MultibaseEncoder<Prefix>): ToString<Link<Data, Format, Alg, Version>, Prefix>
-  toJSON(): { version: V, code: Format, hash: Uint8Array }
-  link(): Link<Data, Format, Alg, V>
+  toString: <Prefix extends string>(base?: MultibaseEncoder<Prefix>) => ToString<Link<Data, Format, Alg, Version>, Prefix>
+  toJSON: () => { version: V, code: Format, hash: Uint8Array }
+  link: () => Link<Data, Format, Alg, V>
 
-  toV1(): Link<Data, Format, Alg, 1>
+  toV1: () => Link<Data, Format, Alg, 1>
 }
 
 export interface LegacyLink<T extends unknown = unknown> extends Link<T, DAG_PB, SHA_256, 0> {

src/traversal.js

@@ -16,7 +16,6 @@ import { base58btc } from './bases/base58.js'
  */
 
 /**
- * @template T
  * @param {object} options
  * @param {CID} options.cid
  * @param {(cid: CID) => Promise<BlockView|null>} options.load

test/test-link.js renamed to test/test-link.spec.js

@@ -39,8 +39,7 @@
       ],
       "multiformats/*": [
         "./src/*.js"
-      ],
-      
+      ]
     }
   },
   "include": [