Drop restriction that newly created protocol objects must using a known protocol code

Author: ntninja

multiaddr/codecs/onion.py

@@ -26,7 +26,7 @@ def to_bytes(proto, string):
 	try:
 		port = int(addr[1], 10)
 	except ValueError as exc:
-		six.raise_from(ValueError("Port number is not an integer"), exc)
+		six.raise_from(ValueError("Port number is not a base 10 integer"), exc)
 	if port not in range(1, 65536):
 		raise ValueError("Port number is not in range(1, 65536)")
 

multiaddr/multiaddr.py

@@ -16,7 +16,7 @@ class Multiaddr(object):
     Multiaddr is a cross-protocol, cross-platform format for representing
     internet addresses. It emphasizes explicitness and self-description.
 
-    Learn more here: http://multiformats.io/multiaddr/
+    Learn more here: https://multiformats.io/multiaddr/
 
     Multiaddrs have both a binary and string representation.
 

multiaddr/protocols.py

@@ -83,10 +83,6 @@ def __init__(self, code, name, codec):
         if not isinstance(codec, six.string_types) and not codec is None:
             raise TypeError("codec must be a string or None")
 
-        #XXX: Why does this exist!?
-        if code not in _CODES and code != 0:
-            raise exceptions.ProtocolNotFoundError(code, "code")
-
         self.code = code
         self.name = name
         self.codec = codec

tests/test_protocols.py

@@ -38,13 +38,6 @@ def test_invalid_code(valid_params, invalid_code):
 	with pytest.raises(TypeError):
 		protocols.Protocol(**valid_params)
 
-@pytest.mark.parametrize("unknown_code", [123])
-def test_unknown_code(valid_params, unknown_code):
-	assert unknown_code not in protocols._CODES
-	valid_params['code'] = unknown_code
-	with pytest.raises(exceptions.ProtocolNotFoundError):
-		protocols.Protocol(**valid_params)
-
 
 @pytest.mark.parametrize("invalid_name", [123, 1.0])
 def test_invalid_name(valid_params, invalid_name):