Merge pull request #48 from numtide/test-all-modules

test all modules

Author: rcambrj

.github/workflows/build-and-release.yaml

@@ -100,6 +100,14 @@ jobs:
       # scan-codeql,
       # scan-intermediate-image
     ]
+    strategy:
+      matrix:
+        module:
+          - "."
+          - "./api"
+          - "./pkg/cluster-handler"
+          - "./pkg/data-handler"
+          - "./pkg/resource-handler"
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
@@ -108,19 +116,23 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
-          go-version-file: go.mod
+          go-version-file: ${{ matrix.module }}/go.mod
 
       - name: Run linter
         uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
+        with:
+          working-directory: ${{ matrix.module }}
+          args: --config=${{ github.workspace }}/.golangci.toml
 
       - name: Run tests
         run: |-
+          cd ${{ matrix.module}}
           go test ./... -coverprofile=./cover.out -covermode=atomic -coverpkg=./...
 
       # - name: Check test coverage
       #   uses: vladopajic/go-test-coverage@cc5012c2cfa84542e02b079141958a885861d326 # v2.17.0
       #   with:
-      #     config: ./.testcoverage.yml
+      #     config: ${{ matrix.module }}/.testcoverage.yml
 
   build-scan-push-container:
     needs: [ test-go ]

pkg/resource-handler/controller/etcd/etcd_controller_internal_test.go

@@ -158,7 +158,7 @@ func TestHandleDeletion_NoFinalizer(t *testing.T) {
 	if err != nil {
 		t.Errorf("handleDeletion() should not error when no finalizer, got: %v", err)
 	}
-	if result.Requeue {
+	if result.RequeueAfter > 0 {
 		t.Error("handleDeletion() should not requeue when no finalizer")
 	}
 }

pkg/resource-handler/controller/etcd/etcd_controller_test.go

@@ -732,7 +732,7 @@ func TestEtcdReconciler_ReconcileNotFound(t *testing.T) {
 	if err != nil {
 		t.Errorf("Reconcile() should not error on NotFound, got: %v", err)
 	}
-	if result.Requeue {
+	if result.RequeueAfter > 0 {
 		t.Errorf("Reconcile() should not requeue on NotFound")
 	}
 }