Skip to content

Commit 4c2d388

Browse files
authored
Refactor mongodb connection uri generation to get username and password from env variables
1 parent 50945c8 commit 4c2d388

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

backend/env/.env.dev

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,8 @@ POSTGRES_PASSWORD = postgres
1212
POSTGRES_DATABASE = bwwc
1313
MONGO_HOST = mongo
1414
MONGO_PORT = 27017
15+
MONGO_USER = bwwc
16+
MONGO_PASSWORD = mongo
17+
MONGO_DB = bwwc
18+
MONGO_PARAMS = ""
1519
DJANGO_ALLOWED_HOSTS = ""

backend/env/.env.example

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,8 @@ POSTGRES_PASSWORD = postgres
1313
POSTGRES_DATABASE = bwwc
1414
MONGO_HOST = localhost
1515
MONGO_PORT = 27017
16+
MONGO_USER = bwwc
17+
MONGO_PASSWORD = mongo
18+
MONGO_DB = bwwc
19+
MONGO_PARAMS = ""
1620
DJANGO_ALLOWED_HOSTS = ""

backend/secretshare/mpce.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,14 @@ def __init__(self, protocol: str = "shamirs", prime: int = 180252380737439):
3535

3636
self.mongo_host = os.environ.get("MONGO_HOST")
3737
self.mongo_port = os.environ.get("MONGO_PORT")
38-
self.mongo_client = MongoClient(
39-
os.environ.get(
40-
"MONGO_HOST", f"mongodb://{self.mongo_host}:{self.mongo_port}/"
41-
)
42-
)
38+
self.mongo_user = os.environ.get("MONGO_USER", "bwwc")
39+
self.mongo_password = os.environ.get("MONGO_PASSWORD")
40+
self.mongo_db = os.environ.get("MONGO_DB", "bwwc")
41+
self.mongo_params = os.environ.get("MONGO_PARAMS", "")
42+
mongo_uri = f"mongodb://{self.mongo_user}:{self.mongo_password}@{self.mongo_host}:{self.mongo_port}/?{self.mongo_params}"
43+
44+
self.mongo_client = MongoClient(mongo_uri)
45+
4346
self.mongo_db = self.mongo_client["bwwc"]
4447
self.session_collection = self.mongo_db["wage_gap"]
4548
self.participant_collection = self.mongo_db["participant"]
@@ -644,4 +647,5 @@ def get_metadata(self, session_id: str) -> dict:
644647
file = self.fs.find_one({ "filename" : f"{session_id}_metadata.json"})
645648
if file is None:
646649
return None
647-
return json.loads(file.read())
650+
return json.loads(file.read())
651+

0 commit comments

Comments
 (0)