Some clean-ups (#305)

* all: remove trailing whitespaces

These trailing whitespaces are useless characters. Many text editors
remove them automatically, and Git also complains about them.

Best to remove them to avoid unwanted changes, and warnings.

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>

* include: add missing std include

When checking header files individually, some of them didn't include
stdbool.h ('bool' type) or stdint.h (uint32_t type).

Add the missing headers to have all these header files self-contained:
they can be compiled alone with analytic tools.

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>

* c: remove unused headers

'clangd' reported a few unused headers. Best to remove them then.

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>

* tests: fix strict-prototypes warning

clangd reported this issue:

  A function declaration without a prototype is deprecated in all versions of C.

We can simply adding 'void', we don't need any arguments there.

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>

* git: ignore compile_commands.json file

It is useful to be used with clangd to enhance a text editor.

This file can be generated with bear, e.g.

  $ make clean
  $ bear --append -- make -j$(nproc) all check

While at it, also ignore .plist files: some CLang diagnostics files.

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>

* git: ignore hidden files / directories

Similar to what is done in the Linux kernel: very likely, hidden files
and directories don't need to be tracked in git. There are exceptions
of course, like the '.github' directory, but we can always force their
inclusions with 'git add -f'.

This will at least ignore the '.cache' directory created by clangd.
Editors tend to create hidden directories and files too, so that would
cover that too.

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>

---------

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>

Author: matttbe

.gitignore

@@ -1,3 +1,4 @@
+.*
 *.o
 *.lo
 *.la
@@ -59,3 +60,5 @@ tests/*.log
 tests/*.trs
 tests/test-suite.log
 README
+compile_commands.json
+*.plist

CODE_OF_CONDUCT.md

@@ -121,11 +121,11 @@ This Code of Conduct is adapted from the [Contributor Covenant][homepage],
 version 2.0, available at
 [https://www.contributor-covenant.org/version/2/0/code_of_conduct.html][v2.0].
 
-Community Impact Guidelines were inspired by 
+Community Impact Guidelines were inspired by
 [Mozilla's code of conduct enforcement ladder][Mozilla CoC].
 
 For answers to common questions about this code of conduct, see the FAQ at
-[https://www.contributor-covenant.org/faq][FAQ]. Translations are available 
+[https://www.contributor-covenant.org/faq][FAQ]. Translations are available
 at [https://www.contributor-covenant.org/translations][translations].
 
 [homepage]: https://www.contributor-covenant.org

include/mptcpd/path_manager.h

@@ -10,6 +10,8 @@
 #ifndef MPTCPD_LIB_PATH_MANAGER_H
 #define MPTCPD_LIB_PATH_MANAGER_H
 
+#include <stdbool.h>
+
 #include <mptcpd/export.h>
 #include <mptcpd/types.h>
 

include/mptcpd/private/configuration.h

@@ -10,6 +10,8 @@
 #ifndef MPTCPD_CONFIGURATION_H
 #define MPTCPD_CONFIGURATION_H
 
+#include <stdint.h>
+
 
 /**
  * Function pointer corresponding to the ELL functions that set the

include/mptcpd/private/id_manager.h

@@ -10,6 +10,8 @@
 #ifndef MPTCPD_PRIVATE_ID_MANAGER_H
 #define MPTCPD_PRIVATE_ID_MANAGER_H
 
+#include <stdbool.h>
+
 #include <mptcpd/export.h>
 #include <mptcpd/types.h>
 

include/mptcpd/private/path_manager.h

@@ -10,6 +10,8 @@
 #ifndef MPTCPD_PRIVATE_PATH_MANAGER_H
 #define MPTCPD_PRIVATE_PATH_MANAGER_H
 
+#include <stdbool.h>
+
 #include <mptcpd/types.h>
 
 

lib/id_manager.c

@@ -14,7 +14,6 @@
 #define _POSIX_C_SOURCE 200112L  ///< For XSI-compliant strerror_r().
 
 #include <assert.h>
-#include <errno.h>
 #include <stdint.h>
 #include <string.h>
 #include <sys/socket.h>

lib/plugin.c

@@ -290,7 +290,7 @@ static void load_plugin(char const *filename)
 static void load_plugins_queue(char const *dir,
                                struct l_queue const* plugins_to_load)
 {
-        struct l_queue_entry const *entry = 
+        struct l_queue_entry const *entry =
                 l_queue_get_entries((struct l_queue *) plugins_to_load);
 
         while (entry) {
@@ -359,8 +359,8 @@ static int load_plugins_all(int const fd,
 }
 
 
-static int load_plugins(char const *dir, 
-                        struct l_queue const *plugins_to_load, 
+static int load_plugins(char const *dir,
+                        struct l_queue const *plugins_to_load,
                         struct mptcpd_pm *pm)
 {
         /**

man/mptcpd.8.in

@@ -129,7 +129,7 @@ overriding plugin priorities
 .TP
 .BI \-\-load\-plugins= PLUGINS
 set plugins to load on startup, where
-.I PLUGINS 
+.I PLUGINS
 is a comma separated list containing one or more plugin names
 
 .TP

src/configuration.c

@@ -15,7 +15,6 @@
 #include <stdio.h>
 #include <stdbool.h>
 #include <argp.h>
-#include <ctype.h>  // For isalnum().
 #include <assert.h>
 #include <sys/types.h>
 #include <sys/stat.h>