Skip to content

Commit 266f781

Browse files
committed
Switch off node-sass
1 parent 1e7705a commit 266f781

File tree

6 files changed

+92
-682
lines changed

6 files changed

+92
-682
lines changed

ee/ui/scripts/ui.build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ setenv_default UI_TITLE "DataStation Enterprise Edition"
1212
setenv_default UI_CSP ""
1313
setenv_default UI_ROOT ""
1414
render ../ui/index.html build/index.html
15-
node-sass ../ui/style.css ./build/style.css
15+
yarn sass ../ui/style.scss ./build/style.css

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"release-desktop": "python3 ./scripts/build.py ./desktop/scripts/release.build",
2020
"release-server": "python3 ./scripts/build.py ./server/scripts/release.build",
2121
"format": "yarn prettier --write \"**/*.js\" \"**/*.test.js\" \"**/*.test.jsx\" \"**/*.ts\" \"**/*.tsx\" \"**/*.css\" \"**/*.json\"",
22-
"test-licenses": "yarn license-checker --production --onlyAllow 'Python-2.0;AFLv2.1;BSD;MIT;Apache-2.0;Apache 2.0;Apache*;ISC;BSD-3-Clause;MIT*;BSD-2-Clause;Unlicense'",
22+
"test-licenses": "npx license-checker --production --onlyAllow 'Python-2.0;AFLv2.1;BSD;MIT;Apache-2.0;Apache 2.0;Apache*;ISC;BSD-3-Clause;MIT*;BSD-2-Clause;Unlicense'",
2323
"generate-test-data": "node --unhandled-rejections=warn ./scripts/generate_test_data.js",
2424
"test": "yarn test-local --coverage",
2525
"test-local": "cross-env NODE_OPTIONS=--unhandled-rejections=warn jest --passWithNoTests --runInBand",
@@ -42,7 +42,6 @@
4242
"json-stringify-safe": "^5.0.1",
4343
"lodash.debounce": "^4.0.8",
4444
"nanoid": "3",
45-
"node-sass": "^8.0.0",
4645
"nodemailer": "^6.7.7",
4746
"openid-client": "^5.4.0",
4847
"papaparse": "^5.3.2",
@@ -53,6 +52,7 @@
5352
"react-dom": "17",
5453
"react-hotkeys-hook": "^3.4.6",
5554
"react-syntax-highlighter": "^15.5.0",
55+
"sass": "^1.60.0",
5656
"shape": "npm:@multiprocess/shape",
5757
"source-map-support": "^0.5.21",
5858
"sql-formatter": "^8.2.0",
@@ -96,7 +96,6 @@
9696
"eslint-plugin-react-hooks": "^4.6.0",
9797
"jest": "^28.1.3",
9898
"jest-canvas-mock": "^2.4.0",
99-
"license-checker": "^25.0.1",
10099
"node-fetch": "2",
101100
"prettier": "^2.7.1",
102101
"prettier-plugin-organize-imports": "^3.0.0",

ui/scripts/ui.build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ setenv_default UI_TITLE "DataStation Desktop CE"
1010
setenv_default UI_CSP ""
1111
setenv_default UI_ROOT ""
1212
render ui/index.html build/index.html
13-
node-sass ./ui/style.css ./build/style.css
13+
yarn sass ./ui/style.scss ./build/style.css

ui/scripts/watch_and_serve.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ yarn build-ui
1111
# Now watch for changes in the background and rebuild
1212
function watch() {
1313
for dir in $(find "$1" -type d); do
14-
fswatch -x --event Created --event Removed --event Renamed --event Updated "$dir" | grep --line-buffered -E "\.(tsx|css|ts|js|jsx)" | xargs -n1 bash -c 'yarn esbuild ui/index.tsx --loader:.ts=tsx --loader:.js=jsx "--external:fs" --bundle --sourcemap --outfile=build/ui.js && node-sass ./ui/style.css ./build/style.css' &
14+
fswatch -x --event Created --event Removed --event Renamed --event Updated "$dir" | grep --line-buffered -E "\.(tsx|css|ts|js|jsx)" | xargs -n1 bash -c 'yarn esbuild ui/index.tsx --loader:.ts=tsx --loader:.js=jsx "--external:fs" --bundle --sourcemap --outfile=build/ui.js && yarn sass ./ui/style.scss ./build/style.css' &
1515
done
1616
}
1717

File renamed without changes.

0 commit comments

Comments
 (0)