Fix #9844 (Passing empty string to requestBrowserDomains crashes client)

Author: jushar

Client/cefweb/CWebCore.cpp

@@ -219,7 +219,7 @@ eURLState CWebCore::GetDomainState(const SString& strURL, bool bOutputDebug)
 SString CWebCore::GetDomainFromURL(const SString& strURL)
 {
     CefURLParts urlParts;
-    if (!CefParseURL(strURL, urlParts) || !urlParts.host.str)
+    if (strURL.empty() || !CefParseURL(strURL, urlParts) || !urlParts.host.str)
         return "";
 
     return UTF16ToMbUTF8(urlParts.host.str);

Client/cefweb/CWebView.cpp

@@ -93,7 +93,7 @@ bool CWebView::LoadURL(const SString& strURL, bool bFilterEnabled, const SString
         return false;
 
     CefURLParts urlParts;
-    if (!CefParseURL(strURL, urlParts))
+    if (strURL.empty() || !CefParseURL(strURL, urlParts))
         return false;            // Invalid URL
 
     // Are we allowed to browse this website?

Client/mods/deathmatch/logic/luadefs/CLuaBrowserDefs.cpp

@@ -167,14 +167,12 @@ int CLuaBrowserDefs::RequestBrowserDomains(lua_State* luaVM)
 
     if (!argStream.HasErrors())
     {
+        // Remove empty URLs
+        pages.erase(std::remove_if(pages.begin(), pages.end(), [](const auto& url) { return url.empty(); }));
+
         // Convert to domains if we got a list of URLs
         if (bIsURL)
-        {
-            for (auto& strURL : pages)
-            {
-                strURL = g_pCore->GetWebCore()->GetDomainFromURL(strURL);
-            }
-        }
+            std::transform(pages.begin(), pages.end(), pages.begin(), [](const auto& url) { return g_pCore->GetWebCore()->GetDomainFromURL(url); });
 
         WebRequestCallback callback = [=](bool bAllow, const std::unordered_set<SString>& domains) {
             // Test if luaVM is still available