Review comments

Author: DryxioGTA

Client/game_sa/CEntitySA.cpp

@@ -665,7 +665,7 @@ bool CEntitySA::SetBoneScale(eBone boneId, const CVector& scale)
     if (!rwBoneMatrix)
         return false;
 
-    RwMatrixScale(rwBoneMatrix, (RwV3d*)&scale, TRANSFORM_BEFORE);
+    RwMatrixScale(rwBoneMatrix, reinterpret_cast<const RwV3d*>(&scale), TRANSFORM_BEFORE);
     return true;
 }
 

Client/mods/deathmatch/logic/CClientPed.cpp

@@ -1130,10 +1130,7 @@ CVector* CClientPed::GetTransformedBonePosition(eBone bone, CVector& vecPosition
 
 bool CClientPed::SetBoneScale(eBone boneId, const CVector& scale)
 {
-    if (!m_pPlayerPed)
-        return false;
-
-    if (boneId < BONE_ROOT || boneId > BONE_LEFTBREAST)
+    if (!m_pPlayerPed || boneId < BONE_ROOT || boneId > BONE_LEFTBREAST)
         return false;
 
     m_boneScales[boneId] = scale;

Client/mods/deathmatch/logic/CClientPed.h

@@ -24,7 +24,7 @@ class CClientPed;
 #include <game/CPad.h>
 #include <game/TaskTypes.h>
 #include <game/CPed.h>
-#include <map>
+#include <unordered_map>
 
 class CAnimBlock;
 class CClientCamera;
@@ -816,13 +816,12 @@ class CClientPed : public CClientStreamElement, public CAntiCheatModule
     bool m_animationOverridedByClient{};
 
     // Bone scaling
-    std::map<eBone, CVector> m_boneScales;
+    std::unordered_map<eBone, CVector> m_boneScales;
 
 public:
     bool SetBoneScale(eBone boneId, const CVector& scale);
     bool GetBoneScale(eBone boneId, CVector& scale) const;
     bool ResetBoneScale(eBone boneId);
     void ResetAllBoneScales();
     void ApplyBoneScales();
-    bool HasBoneScales() const { return !m_boneScales.empty(); }
 };

Client/mods/deathmatch/logic/luadefs/CLuaPedDefs.cpp

@@ -1151,10 +1151,9 @@ bool CLuaPedDefs::ResetElementBoneScale(CClientPed* ped, const std::uint16_t bon
     return ped->ResetBoneScale(static_cast<eBone>(bone));
 }
 
-bool CLuaPedDefs::ResetAllElementBoneScales(CClientPed* ped)
+void CLuaPedDefs::ResetAllElementBoneScales(CClientPed* ped)
 {
     ped->ResetAllBoneScales();
-    return true;
 }
 
 bool CLuaPedDefs::UpdateElementRpHAnim(CClientPed* ped)

Client/mods/deathmatch/logic/luadefs/CLuaPedDefs.h

@@ -64,7 +64,7 @@ class CLuaPedDefs : public CLuaDefs
     static bool SetElementBoneScale(CClientPed* ped, const std::uint16_t bone, const float scaleX, const float scaleY, const float scaleZ);
 
     static bool ResetElementBoneScale(CClientPed* ped, const std::uint16_t bone);
-    static bool ResetAllElementBoneScales(CClientPed* ped);
+    static void ResetAllElementBoneScales(CClientPed* ped);
 
     static bool UpdateElementRpHAnim(CClientPed* ped);