Fix #3015: Ignore empty string in executeBrowserJavascript (#3016)

Sebastian Jura · web-flow · commit 2cd578402eb2 · 2023-05-21T12:33:56.000+03:00
diff --git a/Client/mods/deathmatch/logic/luadefs/CLuaBrowserDefs.cpp b/Client/mods/deathmatch/logic/luadefs/CLuaBrowserDefs.cpp
@@ -459,7 +459,7 @@ int CLuaBrowserDefs::ExecuteBrowserJavascript(lua_State* luaVM)
 
     if (!argStream.HasErrors())
     {
-        if (pWebBrowser->ExecuteJavascript(strJavascriptCode))
+        if (strJavascriptCode.empty() || pWebBrowser->ExecuteJavascript(strJavascriptCode))
         {
             lua_pushboolean(luaVM, true);
             return 1;

Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,7 @@ int CLuaBrowserDefs::ExecuteBrowserJavascript(lua_State* luaVM)`
`459`	`459`
`460`	`460`	`if (!argStream.HasErrors())`
`461`	`461`	`{`
`462`		`- if (pWebBrowser->ExecuteJavascript(strJavascriptCode))`
	`462`	`+ if (strJavascriptCode.empty() \|\| pWebBrowser->ExecuteJavascript(strJavascriptCode))`
`463`	`463`	`{`
`464`	`464`	`lua_pushboolean(luaVM, true);`
`465`	`465`	`return 1;`