Fix #1171: setElementVisibleTo return value (#1601)

Lpsd · web-flow · commit 6941e0b0700a · 2020-08-06T16:20:08.000+01:00
* Fix SetElementVisibleTo return value
diff --git a/Server/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp b/Server/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp
@@ -1342,12 +1342,12 @@ bool CStaticFunctionDefinitions::SetElementVisibleTo(CElement* pElement, CElemen
     {
         CPerPlayerEntity* pEntity = static_cast<CPerPlayerEntity*>(pElement);
         if (bVisible)
-            pEntity->AddVisibleToReference(pReference);
+            return pEntity->AddVisibleToReference(pReference);
         else
-            pEntity->RemoveVisibleToReference(pReference);
+            return pEntity->RemoveVisibleToReference(pReference);
     }
 
-    return true;
+    return false;
 }
 
 bool CStaticFunctionDefinitions::SetElementInterior(CElement* pElement, unsigned char ucInterior, bool bSetPosition, CVector& vecPosition)

Original file line number	Diff line number	Diff line change
`@@ -1342,12 +1342,12 @@ bool CStaticFunctionDefinitions::SetElementVisibleTo(CElement* pElement, CElemen`
`1342`	`1342`	`{`
`1343`	`1343`	`CPerPlayerEntity* pEntity = static_cast<CPerPlayerEntity*>(pElement);`
`1344`	`1344`	`if (bVisible)`
`1345`		`- pEntity->AddVisibleToReference(pReference);`
	`1345`	`+ return pEntity->AddVisibleToReference(pReference);`
`1346`	`1346`	`else`
`1347`		`- pEntity->RemoveVisibleToReference(pReference);`
	`1347`	`+ return pEntity->RemoveVisibleToReference(pReference);`
`1348`	`1348`	`}`
`1349`	`1349`
`1350`		`- return true;`
	`1350`	`+ return false;`
`1351`	`1351`	`}`
`1352`	`1352`
`1353`	`1353`	`bool CStaticFunctionDefinitions::SetElementInterior(CElement* pElement, unsigned char ucInterior, bool bSetPosition, CVector& vecPosition)`