libspeex: Replace our own OOB fix with upstream's chosen one

Author: Dutchman101

vendor/libspeex/libspeex/vorbis_psy.c

@@ -340,16 +340,17 @@ VorbisPsy *vorbis_psy_init(int rate, int n)
     if(halfoc<0)halfoc=0;
     if(halfoc>=P_BANDS-1)halfoc=P_BANDS-1;
     inthalfoc=(int)halfoc;
+    /*If we hit the P_BANDS-1 clamp above, inthalfoc+1 will be out of bounds,
+       even though it will have an interpolation weight of 0.
+      Shift the interval so we don't read past the end of the array.*/
+    if(inthalfoc>=P_BANDS-2)inthalfoc=P_BANDS-2;
     del=halfoc-inthalfoc;
 
-    if (halfoc < P_BANDS-1) { 
     p->noiseoffset[i]=
       p->vi->noiseoff[inthalfoc]*(1.-del) +
       p->vi->noiseoff[inthalfoc+1]*del;
-    } else {
-      p->noiseoffset[i]=
-        p->vi->noiseoff[inthalfoc]*(1.-del);
-}
+
+  }
 #if 0
   _analysis_output_always("noiseoff0",ls,p->noiseoffset,n,1,0,0);
 #endif