Remove redundant / unused code

Author: Lpsd

Client/mods/deathmatch/logic/CClientDisplay.cpp

@@ -13,8 +13,6 @@
 CClientDisplay::CClientDisplay(unsigned long ulID)
 {
     m_ulID = ulID;
-
-    m_ulExpirationTime = 0;
     m_bVisible = true;
     m_Color = SColorRGBA(255, 255, 255, 255);
 }

Client/mods/deathmatch/logic/CClientDisplay.h

@@ -29,11 +29,6 @@ class CClientDisplay
     unsigned long        GetID() const { return m_ulID; }
     virtual eDisplayType GetType() = 0;
 
-    unsigned long GetExpirationTime() const { return m_ulExpirationTime; };
-    void          SetExpirationTime(unsigned long ulTime) { m_ulExpirationTime = ulTime; };
-    unsigned long GetTimeTillExpiration() const { return m_ulExpirationTime - CClientTime::GetTime(); };
-    void          SetTimeTillExpiration(unsigned long ulMs) { m_ulExpirationTime = CClientTime::GetTime() + ulMs; };
-
     virtual const CVector& GetPosition() { return m_vecPosition; };
     virtual void           SetPosition(const CVector& vecPosition) { m_vecPosition = vecPosition; };
 
@@ -47,10 +42,7 @@ class CClientDisplay
     virtual void Render() = 0;
 
 protected:
-    bool IsExpired() const { return (m_ulExpirationTime != 0 && (CClientTime::GetTime() > m_ulExpirationTime)); };
-
     unsigned long m_ulID;
-    unsigned long m_ulExpirationTime;
     bool          m_bVisible;
     CVector       m_vecPosition;
     SColor        m_Color;

Client/mods/deathmatch/logic/CClientVectorGraphic.cpp

@@ -45,7 +45,7 @@ bool CClientVectorGraphic::LoadFromString(std::string strData)
 
 bool CClientVectorGraphic::SetDocument(CXMLNode* node)
 {
-    if (!m_pVectorGraphicDisplay || !node || !node->IsValid())
+    if (!node || !node->IsValid())
         return false;
 
     if (m_pXMLString && m_pXMLString->node != node)
@@ -79,9 +79,6 @@ bool CClientVectorGraphic::RemoveUpdateCallback()
 
 void CClientVectorGraphic::OnUpdate()
 {
-    if (!m_pVectorGraphicDisplay)
-        return;
-
     m_pVectorGraphicDisplay->UpdateTexture();
 
     if (std::holds_alternative<CLuaFunctionRef>(m_updateCallbackRef))

Client/mods/deathmatch/logic/CClientVectorGraphicDisplay.cpp

@@ -25,11 +25,8 @@ CClientVectorGraphicDisplay::CClientVectorGraphicDisplay(CClientVectorGraphic* p
 
 void CClientVectorGraphicDisplay::Render()
 {
-    // When the underlying vector graphic is deleted, this display will be destroyed automatically by the manager.
-    // CClientVectorGraphicDisplay::Render should be called as long as the display manager is still alive.
-    // see CClientDisplayManager::DoPulse
     if (!m_pVectorGraphic || m_pVectorGraphic->IsDestroyed())
-        return SetTimeTillExpiration(1);
+        return;
 
     if (!m_bVisible)
     {